Edit basic Manga information

[Splintorien]

Closes #5

[MajorTanya]

Consider adding more fields, like “About”, “Author”, and “Artist” provided the code doesn’t get too complicated.

Author, Artist, and Description are in PR already, or are you asking for other fields beyond those?

[Xori71]

Consider adding more fields, like “About”, “Author”, and “Artist” provided the code doesn’t get too complicated.

Author, Artist, and Description are in PR already, or are you asking for other fields beyond those?

Yeah, just saw it. I’m sleepy and I missed them before. I will delete the reply, my bad!

[Splintorien]

Commit a745753 has a build error but I still pushed if anyone has an idea of why this is happening. I added a LEFT JOIN and some coalesce to give priority to the fields in the table mangas_edits, but there is an extra parameter of the Manga type that seems to be passed to the mapper

mihon/data/src/main/java/tachiyomi/data/manga/MangaRepositoryImpl.kt:19:66 Type mismatch: inferred type is

KFunction22<Long, Long, String, String?, String?, String?, List<String>?, String, Long, String?, Boolean, Long?, Long?, Boolean, Long, Long, Long, Long, UpdateStrategy, Long, Long, Long?, Manga>

but (Long, String?, String?, String?, String, Long, String, List<String>?, Long, String?, Boolean, Long?, Long?, Boolean, Long, Long, Long, Long, UpdateStrategy, Long, Long, Long?) -> TypeVariable(T) was expected

[Syer10]

Its not worth using coalesce since we would have to modify each and every database query. Take a look at how this fork does it(og field, edited field, and the standard field that takes the edited field when its not null).
https://github.com/jobobby04/TachiyomiSY/blob/master/domain/src/main/java/tachiyomi/domain/manga/model/Manga.kt

Also don't make it a new table, add the columns to the manga table. since there is only going to be 1 edit row per manga row.

[MajorTanya]

I believe they're using a table because that's what AntsyLich suggested in the server

[Syer10]

Its not worth using a table, it will just make it difficult in the long run. Columns are much easier to manage for info that needs to be attached directly to 1 object

[alexandru0-dev]

Any update on this?
It would definitely need a rebase

[Norsze]

You are the update @alexandru0-dev , congrats you are the latest comment 🎉

[alexandru0-dev]

You are the update @alexandru0-dev , congrats you are the latest comment 🎉

Lmao, but I was serious
The PR is ~390 lines changed and it's 1y+ old
The feature seems requested as there are duplicated issues about this feature
Personally I think it is kinda a waste to let this PR die

I can rebase this PR if nobody is willing to do it, but I don't know Kotlin, so if there are requested changes I may not be able to solve them as wanted or at all

Are there any known blockers (excluding the rebase) ?

[Animeboynz]

I can rebase this PR if nobody is willing to do it,

Bruh how do you plan on that, without write access to the authors branch 🤣
Just wait till people get around to it man, people have their own lives and can be busy

[alexandru0-dev]

Bruh how do you plan on that, without write access to the authors branch 🤣

Just creating a new PR from his patchset (?)

Just wait till people get around to it man, people have their own lives and can be busy

Ah for sure, I more than completely understand, as myself I'm the same shoes, and I don't want to pressure anyone
Simply I was simply implying if help is needed to progress this I would gladly help how I can

[Splintorien]

It has indeed been a while since I contributed there 😄 I'll solve the merge conflicts and check if we can merge the PR

[Splintorien]

You are the update @alexandru0-dev , congrats you are the latest comment 🎉

Lmao, but I was serious The PR is ~390 lines changed and it's 1y+ old The feature seems requested as there are duplicated issues about this feature Personally I think it is kinda a waste to let this PR die

I can rebase this PR if nobody is willing to do it, but I don't know Kotlin, so if there are requested changes I may not be able to solve them as wanted or at all

Are there any known blockers (excluding the rebase) ?

iirc there were no known blockers, I just pulled all the changes and fixed the conflicts, seems to work well. I think at the time I was waiting for the final review, then I started a new position in a new country, the PR got forgotten, and there we are a year later 😄

[AntsyLich]

I would like that the custom metadata are on a separate table altogether.

[Syer10]

Its not worth using a table, it will just make it difficult in the long run. Columns are much easier to manage for info that needs to be attached directly to 1 object

[AntsyLich]

Blocked by #1195