Fix JRuby builds / minimum ruby version #1637
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the supported Ruby versions and adjusts the GitHub Actions workflow to use newer Ubuntu images for JRuby testing while pruning older Ruby versions.
- Consolidated the Ruby, JRuby, and Truffleruby version listings in README.md.
- Updated the workflow matrix to specify the appropriate OS for JRuby and added support for Ruby 3.3.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.md | Consolidated version support information for Ruby, JRuby, and Truffleruby. |
| .github/workflows/test.yml | Updated the test workflow to use a variable for the OS and set ubuntu-22.04 for JRuby jobs. |
|
As Ruby 2.7 is now 2 years EOL, maybe a good moment to prune that version as well, WDYT @radar? |
|
Yep, trim it. While you're there, also trim 3.0 (EOL'D almost a year ago). Keep 3.1, despite it EOL'ing in 4 days time. |
Ruby 3.0 EOL was 2024-04-23. **NOTE:** The next release after this is merged should be v2.9.0.
eval
changed the title
JRuby needs an older ubuntu. Ruby >3.4 no longer has benchmark as default gem.
|
@fz-ryanbigg 3.1 it is 👍🏻 |
|
@fz-ryanbigg good to go? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent JRuby builds were failing with errors "Error: Unavailable version 9.2.21.0 for jruby on ubuntu-24.04".
This PR ensures JRuby uses ubuntu-22.04.
It also prunes builds for CRuby 2.5 and 2.6.