Skip to content
This repository has been archived by the owner on May 9, 2021. It is now read-only.

Update project with Laravel 4 #186

Closed
wants to merge 0 commits into from
Closed

Update project with Laravel 4 #186

wants to merge 0 commits into from

Conversation

pokap
Copy link

@pokap pokap commented Dec 30, 2013

This is a big features.
I am not proposing an overhaul of tinyissue, but a passage to Laravel 4.1.

The are lot of modification like rename and move file, logic does not change.
Warning, I have not included the vendors.

If there are problems of integration or other, I remain available to update the PR.

@ryanwinchester
Copy link

Yes Laravel 4.1 support would be amazing

@woolfg
Copy link
Contributor

woolfg commented Jan 17, 2014

+1

1 similar comment
@codivist
Copy link

codivist commented Feb 7, 2014

+1

@woolfg
Copy link
Contributor

woolfg commented Feb 10, 2014

just installed the new version, did a "php composer.phar install" and everything worked fine

@woolfg
Copy link
Contributor

woolfg commented Feb 10, 2014

@pokap did you base your laravel4 upgrade on the master branch as in your version some features are missing which are currently available in the current develop branch. you should also point your pull request to the develop branch.

@pokap
Copy link
Author

pokap commented Feb 13, 2014

@woolfg I can propose a new branch develop like "4.1", you can easily manage merges. What do you think?

@woolfg
Copy link
Contributor

woolfg commented Feb 13, 2014

I would be glad to hear about mikelbring's ideas and plans. afaik he planned to switch to laravel 4 as well?

@pokap
Copy link
Author

pokap commented Feb 14, 2014

@woolfg I don't know the mikelbring's intentions :(

I'm involved in a project via tinyissue but my server doesn't work with laravel 3, I upgraded all code for lavarel 4 and I propose this upgrade.

If @mikelbring doesn't respond, it will be difficult to maintain, or it will go through a real fork.

@woolfg
Copy link
Contributor

woolfg commented Feb 17, 2014

I hope @mikelbring will respond and shed light on the current roadmap. Afaik he wanted to develop a flexible plugin system to cope with all the issues and pull requests.

@akanevsky
Copy link

@pokap I think that it would be easier to integrate your pull request with all the other recent contributions if you based it off of the develop branch. Also, what are the two other commits that are part of this pull request? They don't seem to related to the Laravel update. Thanks.

@pokap pokap closed this Mar 21, 2014
@pokap pokap reopened this Mar 21, 2014
@pokap
Copy link
Author

pokap commented Mar 21, 2014

@akanevsky You're right, I'll take the time to properly rebuild this PR. And update by development with new features.

@pokap
Copy link
Author

pokap commented Apr 3, 2014

@everyone, I create a new PR in #214.

@pokap pokap closed this Apr 3, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants