Conversation
There was a problem hiding this comment.
Pull request overview
This PR upgrades the Gradle wrapper from version 9.2.0 to 9.3.1 (note: the PR title incorrectly states upgrading from 8.11.1). The changes include updated wrapper scripts and the wrapper JAR binary.
Changes:
- Updated Gradle distribution URL to version 9.3.1
- Removed CLASSPATH-related code from wrapper scripts (standard Gradle 9.x wrapper behavior)
- Updated gradle-wrapper.jar binary
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| gradle/wrapper/gradle-wrapper.properties | Updated distribution URL from 9.2.0 to 9.3.1 |
| gradlew | Removed CLASSPATH variable declarations and references from Unix wrapper script |
| gradlew.bat | Removed CLASSPATH variable declaration and reference from Windows wrapper script |
| gradle/wrapper/gradle-wrapper.jar | Binary update to Gradle 9.3.1 wrapper JAR |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.2.0-bin.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.3.1-bin.zip |
There was a problem hiding this comment.
The PR description mentions several changes that are not present in this pull request:
- "Updated CI workflows to use compatible Java versions"
- "Updated build configurations for Gradle 9.x compatibility"
- "Added migration notes for Java 21 compatibility"
- "Added Paparazzi test configurations and snapshots"
The actual changes only include updates to the Gradle wrapper files (gradlew, gradlew.bat, gradle-wrapper.properties, and gradle-wrapper.jar). Either these other files should be included in this PR, or the description should be updated to accurately reflect the scope of changes. If these changes are in other files not shown in the diff, please verify they are part of the PR.
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.2.0-bin.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.3.1-bin.zip |
There was a problem hiding this comment.
The PR title and description claim this upgrades Gradle from 8.11.1 to 9.3.1, but the actual change shows upgrading from 9.2.0 to 9.3.1. The previous version was 9.2.0, not 8.11.1 as stated in the title. Please update the PR title and description to accurately reflect that this is upgrading from 9.2.0 to 9.3.1.
Description
This PR upgrades the Gradle wrapper from 8.11.1 to version 9.3.1.
This upgrade includes:
Type of change
How Has This Been Tested?
Checklist: