Skip to content

Inline image component Issue#498 #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Azadios wants to merge 2 commits into
base: develop
Choose a base branch
from
+280 −101
Open

Inline image component Issue#498 #510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d50ff72
add inline image component
Azadios Jan 22, 2026
60901c3
allow inline image to take max width
Azadios Mar 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion multiplatform-markdown-renderer-coil2/api/jvm/multiplatform-markdown-renderer-coil2.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ public final class com/mikepenz/markdown/coil2/Coil2ImageTransformerImpl : com/m
public static final field $stable I
public static final field INSTANCE Lcom/mikepenz/markdown/coil2/Coil2ImageTransformerImpl;
public fun intrinsicSize-bSu-EZI (Landroidx/compose/ui/graphics/painter/Painter;Landroidx/compose/runtime/Composer;I)J
public fun placeholderConfig-PO73lzk (Landroidx/compose/ui/unit/Density;JJ)Lcom/mikepenz/markdown/model/PlaceholderConfig;
public fun placeholderConfig-JRj2zQI (Ljava/lang/String;Landroidx/compose/ui/unit/Density;JLcom/mikepenz/markdown/model/InlineImageWidth;JLkotlin/jvm/functions/Function2;)Lcom/mikepenz/markdown/model/PlaceholderConfig;
public fun transform (Ljava/lang/String;Landroidx/compose/runtime/Composer;I)Lcom/mikepenz/markdown/model/ImageData;
}

Expand Down
2 changes: 1 addition & 1 deletion multiplatform-markdown-renderer-coil3/api/jvm/multiplatform-markdown-renderer-coil3.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ public final class com/mikepenz/markdown/coil3/Coil3ImageTransformerImpl : com/m
public static final field $stable I
public static final field INSTANCE Lcom/mikepenz/markdown/coil3/Coil3ImageTransformerImpl;
public fun intrinsicSize-bSu-EZI (Landroidx/compose/ui/graphics/painter/Painter;Landroidx/compose/runtime/Composer;I)J
public fun placeholderConfig-PO73lzk (Landroidx/compose/ui/unit/Density;JJ)Lcom/mikepenz/markdown/model/PlaceholderConfig;
public fun placeholderConfig-JRj2zQI (Ljava/lang/String;Landroidx/compose/ui/unit/Density;JLcom/mikepenz/markdown/model/InlineImageWidth;JLkotlin/jvm/functions/Function2;)Lcom/mikepenz/markdown/model/PlaceholderConfig;
public fun transform (Ljava/lang/String;Landroidx/compose/runtime/Composer;I)Lcom/mikepenz/markdown/model/ImageData;
}

6 changes: 3 additions & 3 deletions multiplatform-markdown-renderer-m2/api/jvm/multiplatform-markdown-renderer-m2.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@ public final class com/mikepenz/markdown/m2/ComposableSingletons$MarkdownKt {
public static final field INSTANCE Lcom/mikepenz/markdown/m2/ComposableSingletons$MarkdownKt;
public fun <init> ()V
public final fun getLambda$1112484843$multiplatform_markdown_renderer_m2 ()Lkotlin/jvm/functions/Function5;
public final fun getLambda$1438648568$multiplatform_markdown_renderer_m2 ()Lkotlin/jvm/functions/Function3;
public final fun getLambda$1685186697$multiplatform_markdown_renderer_m2 ()Lkotlin/jvm/functions/Function3;
public final fun getLambda$1739313048$multiplatform_markdown_renderer_m2 ()Lkotlin/jvm/functions/Function3;
public final fun getLambda$1405124674$multiplatform_markdown_renderer_m2 ()Lkotlin/jvm/functions/Function3;
public final fun getLambda$1890655630$multiplatform_markdown_renderer_m2 ()Lkotlin/jvm/functions/Function3;
public final fun getLambda$1996475994$multiplatform_markdown_renderer_m2 ()Lkotlin/jvm/functions/Function5;
public final fun getLambda$598402550$multiplatform_markdown_renderer_m2 ()Lkotlin/jvm/functions/Function5;
public final fun getLambda$925370143$multiplatform_markdown_renderer_m2 ()Lkotlin/jvm/functions/Function3;
}

public final class com/mikepenz/markdown/m2/MarkdownColorsKt {
Expand Down
6 changes: 3 additions & 3 deletions multiplatform-markdown-renderer-m3/api/jvm/multiplatform-markdown-renderer-m3.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@ public final class com/mikepenz/markdown/m3/ComposableSingletons$MarkdownKt {
public static final field INSTANCE Lcom/mikepenz/markdown/m3/ComposableSingletons$MarkdownKt;
public fun <init> ()V
public final fun getLambda$-398669803$multiplatform_markdown_renderer_m3 ()Lkotlin/jvm/functions/Function5;
public final fun getLambda$-71702210$multiplatform_markdown_renderer_m3 ()Lkotlin/jvm/functions/Function3;
public final fun getLambda$115412490$multiplatform_markdown_renderer_m3 ()Lkotlin/jvm/functions/Function5;
public final fun getLambda$441576215$multiplatform_markdown_renderer_m3 ()Lkotlin/jvm/functions/Function3;
public final fun getLambda$688114344$multiplatform_markdown_renderer_m3 ()Lkotlin/jvm/functions/Function3;
public final fun getLambda$742240695$multiplatform_markdown_renderer_m3 ()Lkotlin/jvm/functions/Function3;
public final fun getLambda$408052321$multiplatform_markdown_renderer_m3 ()Lkotlin/jvm/functions/Function3;
public final fun getLambda$893583277$multiplatform_markdown_renderer_m3 ()Lkotlin/jvm/functions/Function3;
public final fun getLambda$999403641$multiplatform_markdown_renderer_m3 ()Lkotlin/jvm/functions/Function5;
}

Expand Down
41 changes: 32 additions & 9 deletions multiplatform-markdown-renderer/api/jvm/multiplatform-markdown-renderer.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ public final class com/mikepenz/markdown/compose/ComposableSingletons$MarkdownKt
public final class com/mikepenz/markdown/compose/ComposeLocalKt {
public static final fun getLocalBulletListHandler ()Landroidx/compose/runtime/ProvidableCompositionLocal;
public static final fun getLocalImageTransformer ()Landroidx/compose/runtime/ProvidableCompositionLocal;
public static final fun getLocalInlineImageWidth ()Landroidx/compose/runtime/ProvidableCompositionLocal;
public static final fun getLocalMarkdownAnimations ()Landroidx/compose/runtime/ProvidableCompositionLocal;
public static final fun getLocalMarkdownAnnotator ()Landroidx/compose/runtime/ProvidableCompositionLocal;
public static final fun getLocalMarkdownColors ()Landroidx/compose/runtime/ProvidableCompositionLocal;
Expand Down Expand Up @@ -78,6 +79,7 @@ public final class com/mikepenz/markdown/compose/components/ComposableSingletons
public fun <init> ()V
public final fun getLambda$-1079294572$multiplatform_markdown_renderer ()Lkotlin/jvm/functions/Function3;
public final fun getLambda$-1347673484$multiplatform_markdown_renderer ()Lkotlin/jvm/functions/Function3;
public final fun getLambda$-1643949077$multiplatform_markdown_renderer ()Lkotlin/jvm/functions/Function3;
public final fun getLambda$-1690655072$multiplatform_markdown_renderer ()Lkotlin/jvm/functions/Function3;
public final fun getLambda$-1755130397$multiplatform_markdown_renderer ()Lkotlin/jvm/functions/Function3;
public final fun getLambda$-1794801381$multiplatform_markdown_renderer ()Lkotlin/jvm/functions/Function3;
Expand Down Expand Up @@ -115,6 +117,7 @@ public final class com/mikepenz/markdown/compose/components/CurrentComponentsBri
public final fun getHeading6 ()Lkotlin/jvm/functions/Function3;
public final fun getHorizontalRule ()Lkotlin/jvm/functions/Function3;
public final fun getImage ()Lkotlin/jvm/functions/Function3;
public final fun getInlineImage ()Lkotlin/jvm/functions/Function3;
public final fun getOrderedList ()Lkotlin/jvm/functions/Function3;
public final fun getParagraph ()Lkotlin/jvm/functions/Function3;
public final fun getSetextHeading1 ()Lkotlin/jvm/functions/Function3;
Expand Down Expand Up @@ -158,6 +161,7 @@ public abstract interface class com/mikepenz/markdown/compose/components/Markdow
public abstract fun getHeading6 ()Lkotlin/jvm/functions/Function3;
public abstract fun getHorizontalRule ()Lkotlin/jvm/functions/Function3;
public abstract fun getImage ()Lkotlin/jvm/functions/Function3;
public abstract fun getInlineImage ()Lkotlin/jvm/functions/Function3;
public abstract fun getOrderedList ()Lkotlin/jvm/functions/Function3;
public abstract fun getParagraph ()Lkotlin/jvm/functions/Function3;
public abstract fun getSetextHeading1 ()Lkotlin/jvm/functions/Function3;
Expand All @@ -168,8 +172,8 @@ public abstract interface class com/mikepenz/markdown/compose/components/Markdow
}

public final class com/mikepenz/markdown/compose/components/MarkdownComponentsKt {
public static final fun markdownComponents (Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function4;)Lcom/mikepenz/markdown/compose/components/MarkdownComponents;
public static synthetic fun markdownComponents$default (Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function4;ILjava/lang/Object;)Lcom/mikepenz/markdown/compose/components/MarkdownComponents;
public static final fun markdownComponents (Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function4;)Lcom/mikepenz/markdown/compose/components/MarkdownComponents;
public static synthetic fun markdownComponents$default (Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function3;Lkotlin/jvm/functions/Function4;ILjava/lang/Object;)Lcom/mikepenz/markdown/compose/components/MarkdownComponents;
}

public final class com/mikepenz/markdown/compose/elements/ComposableSingletons$MarkdownCodeKt {
Expand Down Expand Up @@ -206,6 +210,10 @@ public final class com/mikepenz/markdown/compose/elements/MarkdownImageKt {
public static final fun MarkdownImage (Ljava/lang/String;Lorg/intellij/markdown/ast/ASTNode;Landroidx/compose/runtime/Composer;I)V
}

public final class com/mikepenz/markdown/compose/elements/MarkdownInlineImageKt {
public static final fun MarkdownInlineImage (Ljava/lang/String;Lorg/intellij/markdown/ast/ASTNode;Landroidx/compose/runtime/Composer;I)V
}

public final class com/mikepenz/markdown/compose/elements/MarkdownListKt {
public static final fun MarkdownBulletList (Ljava/lang/String;Lorg/intellij/markdown/ast/ASTNode;Landroidx/compose/ui/text/TextStyle;ILkotlin/jvm/functions/Function1;Lkotlin/jvm/functions/Function1;Landroidx/compose/runtime/Composer;II)V
public static final fun MarkdownListItems (Ljava/lang/String;Lorg/intellij/markdown/ast/ASTNode;ILkotlin/jvm/functions/Function1;Lkotlin/jvm/functions/Function1;Lkotlin/jvm/functions/Function5;Landroidx/compose/runtime/Composer;II)V
Expand All @@ -225,11 +233,10 @@ public final class com/mikepenz/markdown/compose/elements/MarkdownTableKt {
}

public final class com/mikepenz/markdown/compose/elements/MarkdownTextKt {
public static final fun MarkdownText (Landroidx/compose/ui/text/AnnotatedString;Landroidx/compose/ui/Modifier;Landroidx/compose/ui/text/TextStyle;Lcom/mikepenz/markdown/compose/extendedspans/ExtendedSpans;Landroidx/compose/runtime/Composer;II)V
public static final fun MarkdownText (Landroidx/compose/ui/text/AnnotatedString;Landroidx/compose/ui/Modifier;Landroidx/compose/ui/text/TextStyle;Lkotlin/jvm/functions/Function2;Landroidx/compose/runtime/Composer;II)V
public static final fun MarkdownText (Ljava/lang/String;Landroidx/compose/ui/Modifier;Landroidx/compose/ui/text/TextStyle;Landroidx/compose/runtime/Composer;II)V
public static final fun MarkdownText (Landroidx/compose/ui/text/AnnotatedString;Lorg/intellij/markdown/ast/ASTNode;Landroidx/compose/ui/Modifier;Landroidx/compose/ui/text/TextStyle;Lcom/mikepenz/markdown/compose/extendedspans/ExtendedSpans;Landroidx/compose/runtime/Composer;II)V
public static final fun MarkdownText (Landroidx/compose/ui/text/AnnotatedString;Lorg/intellij/markdown/ast/ASTNode;Landroidx/compose/ui/Modifier;Landroidx/compose/ui/text/TextStyle;Lkotlin/jvm/functions/Function2;Landroidx/compose/runtime/Composer;II)V
public static final fun MarkdownText (Ljava/lang/String;Lorg/intellij/markdown/ast/ASTNode;Landroidx/compose/ui/Modifier;Landroidx/compose/ui/text/TextStyle;Landroidx/compose/runtime/Composer;II)V
public static final fun MarkdownText (Ljava/lang/String;Lorg/intellij/markdown/ast/ASTNode;Landroidx/compose/ui/text/TextStyle;Landroidx/compose/ui/Modifier;Lorg/intellij/markdown/IElementType;Lcom/mikepenz/markdown/annotator/AnnotatorSettings;Landroidx/compose/runtime/Composer;II)V
public static final fun createImageInlineTextContent (Lcom/mikepenz/markdown/model/PlaceholderConfig;Lcom/mikepenz/markdown/model/ImageTransformer;Lcom/mikepenz/markdown/model/MarkdownImageState;)Landroidx/compose/foundation/text/InlineTextContent;
}

public final class com/mikepenz/markdown/compose/elements/material/TextWrapperKt {
Expand Down Expand Up @@ -477,14 +484,30 @@ public final class com/mikepenz/markdown/model/ImageData {
}

public abstract interface class com/mikepenz/markdown/model/ImageTransformer {
public static final field Companion Lcom/mikepenz/markdown/model/ImageTransformer$Companion;
public static final field DEFAULT_IMAGE_SIDE_LENGTH_DP F
public fun intrinsicSize-bSu-EZI (Landroidx/compose/ui/graphics/painter/Painter;Landroidx/compose/runtime/Composer;I)J
public fun placeholderConfig-PO73lzk (Landroidx/compose/ui/unit/Density;JJ)Lcom/mikepenz/markdown/model/PlaceholderConfig;
public fun placeholderConfig-JRj2zQI (Ljava/lang/String;Landroidx/compose/ui/unit/Density;JLcom/mikepenz/markdown/model/InlineImageWidth;JLkotlin/jvm/functions/Function2;)Lcom/mikepenz/markdown/model/PlaceholderConfig;
public static synthetic fun placeholderConfig-JRj2zQI$default (Lcom/mikepenz/markdown/model/ImageTransformer;Ljava/lang/String;Landroidx/compose/ui/unit/Density;JLcom/mikepenz/markdown/model/InlineImageWidth;JLkotlin/jvm/functions/Function2;ILjava/lang/Object;)Lcom/mikepenz/markdown/model/PlaceholderConfig;
public abstract fun transform (Ljava/lang/String;Landroidx/compose/runtime/Composer;I)Lcom/mikepenz/markdown/model/ImageData;
}

public final class com/mikepenz/markdown/model/ImageTransformer$Companion {
public static final field DEFAULT_IMAGE_SIDE_LENGTH_DP F
}

public final class com/mikepenz/markdown/model/ImageTransformer$DefaultImpls {
public static fun intrinsicSize-bSu-EZI (Lcom/mikepenz/markdown/model/ImageTransformer;Landroidx/compose/ui/graphics/painter/Painter;Landroidx/compose/runtime/Composer;I)J
public static fun placeholderConfig-PO73lzk (Lcom/mikepenz/markdown/model/ImageTransformer;Landroidx/compose/ui/unit/Density;JJ)Lcom/mikepenz/markdown/model/PlaceholderConfig;
public static fun placeholderConfig-JRj2zQI (Lcom/mikepenz/markdown/model/ImageTransformer;Ljava/lang/String;Landroidx/compose/ui/unit/Density;JLcom/mikepenz/markdown/model/InlineImageWidth;JLkotlin/jvm/functions/Function2;)Lcom/mikepenz/markdown/model/PlaceholderConfig;
public static synthetic fun placeholderConfig-JRj2zQI$default (Lcom/mikepenz/markdown/model/ImageTransformer;Ljava/lang/String;Landroidx/compose/ui/unit/Density;JLcom/mikepenz/markdown/model/InlineImageWidth;JLkotlin/jvm/functions/Function2;ILjava/lang/Object;)Lcom/mikepenz/markdown/model/PlaceholderConfig;
}

public final class com/mikepenz/markdown/model/InlineImageWidth : java/lang/Enum {
public static final field IMAGE_WIDTH Lcom/mikepenz/markdown/model/InlineImageWidth;
public static final field MAX_WIDTH Lcom/mikepenz/markdown/model/InlineImageWidth;
public static fun getEntries ()Lkotlin/enums/EnumEntries;
public static fun valueOf (Ljava/lang/String;)Lcom/mikepenz/markdown/model/InlineImageWidth;
public static fun values ()[Lcom/mikepenz/markdown/model/InlineImageWidth;
}
Comment on lines 486 to 511
Copy link

Copilot AI Feb 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JVM API dump shows ImageTransformer.placeholderConfig as placeholderConfig-cSwnlzA(String, Density, long) (single Size), which doesn’t match the source signature (it should include both containerSize and imageSize, plus the optional callback). Please re-run the API generation after the code compiles so the published ABI matches the Kotlin source.

Copilot uses AI. Check for mistakes.

public final class com/mikepenz/markdown/model/Input {
Expand Down Expand Up @@ -637,7 +660,7 @@ public final class com/mikepenz/markdown/model/NoOpImageTransformerImpl : com/mi
public static final field $stable I
public fun <init> ()V
public fun intrinsicSize-bSu-EZI (Landroidx/compose/ui/graphics/painter/Painter;Landroidx/compose/runtime/Composer;I)J
public fun placeholderConfig-PO73lzk (Landroidx/compose/ui/unit/Density;JJ)Lcom/mikepenz/markdown/model/PlaceholderConfig;
public fun placeholderConfig-JRj2zQI (Ljava/lang/String;Landroidx/compose/ui/unit/Density;JLcom/mikepenz/markdown/model/InlineImageWidth;JLkotlin/jvm/functions/Function2;)Lcom/mikepenz/markdown/model/PlaceholderConfig;
public fun transform (Ljava/lang/String;Landroidx/compose/runtime/Composer;I)Lcom/mikepenz/markdown/model/ImageData;
}

Expand Down
Loading