Skip to content

Add testing against the Python 3.13 release #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

miketheman
Copy link
Owner

@miketheman miketheman commented Aug 3, 2024

Add testing against the Python 3.13 beta release.

  • .github/workflows/python.yml

    • Add 3.13 to the python-version matrix.
  • pyproject.toml

    • Add 3.13 to the classifiers section under Programming Language :: Python.

Add testing against the Python 3.13 beta release.

- **.github/workflows/python.yml**
  - Add `3.13` to the `python-version` matrix.
  - Add `allow-prereleases: true` to the `with` section of `actions/setup-python@v5`.

- **pyproject.toml**
  - Add `3.13` to the `classifiers` section under `Programming Language :: Python`.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/miketheman/pytest-socket?shareId=XXXX-XXXX-XXXX-XXXX).
@miketheman
Copy link
Owner Author

miketheman commented Sep 8, 2024

Waiting on a release from greenlet to support 3.13: python-greenlet/greenlet#396 Released in greenlet 3.1.0

@miketheman miketheman changed the title Add testing against the Python 3.13 beta release Add testing against the Python 3.13 release Oct 11, 2024
Copy link

codeclimate bot commented Oct 11, 2024

Code Climate has analyzed commit dbab20f and detected 0 issues on this pull request.

View more on Code Climate.

@miketheman miketheman requested a review from Copilot March 4, 2025 20:41
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR adds testing for the Python 3.13 beta release by updating configuration files and adjusting type annotations in testing utilities. The key changes include:

  • Adding Python 3.13 support in the GitHub Actions workflow.
  • Updating the Python classifiers and minimum version in pyproject.toml.
  • Adjusting type annotations in pytest_socket.py to use built-in generic types.

Reviewed Changes

File Description
pyproject.toml Added Python 3.13 classifier and bumped the minimum Python version to 3.9.
.pre-commit-config.yaml Updated pyupgrade arguments to require Python 3.9+.
.github/workflows/python.yml Removed Python 3.8 and added Python 3.13 to the CI testing matrix.
pytest_socket.py Converted type annotations from typing generics to built-in generics for consistency with Python 3.9+.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

pyproject.toml:33

  • Ensure that upgrading the minimum Python version from 3.8 to 3.9 is intentional and aligns with your support strategy for older versions of Python.
python = "^3.9"

.github/workflows/python.yml:22

  • Verify that removing Python 3.8 from the CI matrix is consistent with the intended project compatibility requirements.
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]

pytest_socket.py:77

  • Confirm that transitioning to built-in generic types (list[str], dict[str, set[str]]) is compatible with your development and documentation tools, given the minimum version bump.
allow_hosts: typing.Union[str, list[str], None]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant