-
-
Notifications
You must be signed in to change notification settings - Fork 47
feat: support cidr blocks in --allow-hosts #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Any chance of getting this merged? Would absolutely love this feature for our CI pipelines! |
We've been pointing to our fork. Unfortunately it doesn't seem these pull requests are looked at. We have a case where we are going to need the |
They do get looked at - this specific one is failing a check which would need to be resolved. |
A complexity check off by one...? OK, I can fix it. I appreciate your work, it just would have been nice to get an update or hint that we'd like to merge it |
Code Climate has analyzed commit 79ccf47 and detected 0 issues on this pull request. View more on Code Climate. |
@miketheman should be all set now! |
@miketheman @emhagman how could I help to get this merged? Should I open a new PR fixing the conflict ? |
@miketheman Any chance of getting this merged, or @mgaitan's alternative #185? |
I'd just take #185 over this. Don't want to fix conflicts, this has been open forever. We've just been using our fork forever now. |
This feature allows
--allow-hosts
to support CIDR blocks. This is useful inside Docker since different services can get any range of IPs (typically on 172.17.0.0/16 or 172.20.0.0/16) and pytest-socket doesn't support hostnames.I can also add hostname support if we think that is useful.