Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Massive rewrite of SSH section for 2025's authentication changes #266

Merged
merged 2 commits into from
Mar 14, 2025

Conversation

obilaniu
Copy link
Contributor

@obilaniu obilaniu commented Mar 3, 2025

No description provided.

@obilaniu obilaniu force-pushed the ssh-keys branch 4 times, most recently from 72d7516 to d3f6b5a Compare March 3, 2025 08:24
@btravouillon btravouillon requested review from ahmam and milaflq March 3, 2025 23:50
Copy link
Collaborator

@btravouillon btravouillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive work! ❤️
Some comments to open discussion and one request to move one section above the others.

@obilaniu obilaniu force-pushed the ssh-keys branch 3 times, most recently from b31bf14 to a9fbde5 Compare March 4, 2025 16:34
@btravouillon btravouillon self-requested a review March 11, 2025 14:53
Copy link
Contributor

@ahmam ahmam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deep work ❤️

Copy link
Collaborator

@btravouillon btravouillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@btravouillon btravouillon merged commit 4fb9337 into mila-iqia:master Mar 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants