Skip to content

Commit

Permalink
Reduce printed error when making reports
Browse files Browse the repository at this point in the history
  • Loading branch information
pierre.delaunay committed Jun 26, 2024
1 parent 5bb8e13 commit ac8646a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion milabench/commands/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -659,7 +659,7 @@ def _argv(self, **_) -> List:
else ["--multi_gpu"]
)

cpu_per_process = self.resolve_argument('--cpus_per_gpu')
cpu_per_process = self.pack.resolve_argument('--cpus_per_gpu')
return [
# -- Run the command in the right venv
# This could be inside the SSH Command
Expand Down
5 changes: 3 additions & 2 deletions milabench/report.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def _make_row(summary, compare, config, query=None):
"enabled": is_enabled,
}

if not summary:
if not summary or summary.get("empty", False):
return row

# Count not running an enabled benchmark as a failure
Expand Down Expand Up @@ -218,7 +218,8 @@ def make_dataframe(summary, compare=None, weights=None, query=None):
"n": 0,
"successes": 0,
"failures": 0,
"enabled": weights[key]["enabled"]
"enabled": weights[key]["enabled"],
"empty": True
}

if weights is None:
Expand Down

0 comments on commit ac8646a

Please sign in to comment.