Add an extension for Enzyme #83
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsmoses
reviewed
Sep 8, 2025
| using StochasticRounding | ||
| import StochasticRounding: stochastic_round | ||
|
|
||
| function Enzyme.typetree_inner(::Type{Float32sr}, ctx, dl, seen::Enzyme.Compiler.TypeTreeTable) |
There was a problem hiding this comment.
so as is this can result in some errors, specifically if an all-zero bits is not a valid zero, or in reverse mode of a 32-bit floating point add is not a correct add.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires EnzymeAD/Enzyme.jl#2551
It's a little bit "weird" in that we tell Enzyme to just treat this as a Float32 and then use a custom rule for
stochastic_round.During Reverse mode we are performing accumulation and this strategy would not perform stochastic rounding for those operations.