Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add logs for check health failed #39208

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

weiliu1031
Copy link
Contributor

No description provided.

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jan 13, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 13, 2025
Copy link
Contributor

mergify bot commented Jan 13, 2025

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 13, 2025

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.17%. Comparing base (3e788f0) to head (73c10f3).
Report is 20 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #39208      +/-   ##
==========================================
- Coverage   81.17%   81.17%   -0.01%     
==========================================
  Files        1399     1399              
  Lines      197583   197589       +6     
==========================================
+ Hits       160386   160390       +4     
- Misses      31572    31575       +3     
+ Partials     5625     5624       -1     
Components Coverage Δ
Client 79.53% <ø> (ø)
Core 69.70% <ø> (ø)
Go 83.10% <100.00%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
internal/datacoord/server.go 73.45% <100.00%> (ø)
internal/datacoord/services.go 85.65% <100.00%> (+0.02%) ⬆️
internal/http/healthz/healthz_handler.go 73.43% <100.00%> (+2.46%) ⬆️
internal/querycoordv2/server.go 78.97% <100.00%> (+0.02%) ⬆️

... and 29 files with indirect coverage changes

@weiliu1031 weiliu1031 force-pushed the add_logs_for_check_health branch from 7b4dad5 to 8565d01 Compare January 14, 2025 02:32
@weiliu1031 weiliu1031 force-pushed the add_logs_for_check_health branch from 8565d01 to 73c10f3 Compare January 14, 2025 03:55
Copy link
Contributor

mergify bot commented Jan 14, 2025

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@weiliu1031
Copy link
Contributor Author

rerun go-sdk

@mergify mergify bot added the ci-passed label Jan 14, 2025
@tedxu
Copy link
Contributor

tedxu commented Jan 15, 2025

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tedxu, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit d2834a1 into milvus-io:master Jan 15, 2025
20 checks passed
weiliu1031 added a commit to weiliu1031/milvus that referenced this pull request Jan 15, 2025
sre-ci-robot pushed a commit that referenced this pull request Jan 16, 2025
gifi-siby pushed a commit to gifi-siby/milvus that referenced this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants