Refactor: Move Properties to pkg as Public API #5402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Properties are leveraged by many pieces of Minder, including providers, and should be considered a public API instead of being in our internal package. The idea is to move properties to `pkg`. However, the underlying service package will remain internal, as it is a minder-server implementation detail. This commit fixes the affected functions to refer to the public API to access properties Signed-off-by: Kugamoorthy Gajananan <[email protected]>
|
@JAORMX , I locally tested via |
|
@gajananan you might need to run |
Properties are leveraged by many pieces of Minder, including providers, and should be considered a public API instead of being in our internal package. The idea is to move properties to `pkg`. However, the underlying service package will remain internal, as it is a minder-server implementation detail. This commit includes uncommitted changes found in the previous commit. The was done aftering run 'make gen'. Signed-off-by: Kugamoorthy Gajananan <[email protected]>
Sure, I did that and pushed the code. |
Properties are leveraged by many pieces of Minder, including providers, and should be considered a public API instead of being in our internal package. The idea is to move properties to `pkg`. However, the underlying service package will remain internal, as it is a minder-server implementation detail. This commit includes changes after running 1. `make bootstrap` again to resolve conflicts in the following files - internal/proto/internal.pb.go - pkg/api/protobuf/go/minder/v1/minder.pb.go 2. `make gen` Signed-off-by: Kugamoorthy Gajananan <[email protected]>
evankanderson
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Properties are leveraged by many pieces of Minder, including providers, and should be considered a public API instead of being in our internal package. The idea is to move properties to
pkg.However, the underlying service package will remain internal, as it is a minder-server implementation detail.
This commit fixes the affected functions to refer to the public API to access properties
Ref: #4699
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: