Add metrics and additional logging for Data Sources #5404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evankanderson
previously approved these changes
Feb 4, 2025
Comment on lines
+74
to
+76
| dataSourceLatencyHistogram, err = meter.Int64Histogram( | ||
| "datasource.rest.latency", | ||
| metric.WithDescription("Latency of data source requests in milliseconds"), |
There was a problem hiding this comment.
Record the unit with the metric:
Suggested change
| dataSourceLatencyHistogram, err = meter.Int64Histogram( | |
| "datasource.rest.latency", | |
| metric.WithDescription("Latency of data source requests in milliseconds"), | |
| dataSourceLatencyHistogram, err = meter.Int64Histogram( | |
| "datasource.rest.latency", | |
| metric.WithDescription("Latency of data source requests in milliseconds"), | |
| metric.WithUnit("ms"), |
internal/datasources/rest/handler.go
Outdated
Comment on lines
67
to
70
| dataSourceRequestCounter, err = meter.Int64Counter( | ||
| "datasource.rest.request", | ||
| metric.WithDescription("Total number of data source requests issued"), | ||
| ) |
There was a problem hiding this comment.
If we're keeping a histogram, we don't need a separate counter -- the top bin of the histogram will give us the total counts.
eleftherias
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.
Fixes mindersec/minder-rules-and-profiles#304
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: