-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix 修复表格固定列,表头样式不统一问题; #500
Conversation
WalkthroughThe pull request introduces styling modifications to various Element UI components in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
web/src/assets/styles/resources/element.scss (1)
14-16
: LGTM! The changes effectively address the fixed column header style inconsistency.The use of
!
to force consistent background colors across all table header cells, including fixed columns, successfully resolves the styling inconsistency. The implementation properly handles both light and dark themes.Consider adding a comment to explain why the
!
important override is necessary, to help future maintainers understand its purpose:.el-table th.el-table__cell{ + /* Force consistent background colors for all header cells, including fixed columns */ @apply font-500 text-dark-9 dark-text-gray-1 !bg-gray-100 !dark:bg-dark-5; }
Summary by CodeRabbit
New Features
Bug Fixes
Style