Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed execute_adb_command to explicitly use adb as a prefix and improved README.md #4

Closed
wants to merge 4 commits into from

Conversation

edgan
Copy link
Contributor

@edgan edgan commented Mar 24, 2025

Changed execute_adb_command to explicitly use adb as a prefix, and to validate if the adb executable is available.

See:
#3

edgan added 2 commits March 23, 2025 18:14
Changed execute_adb_command to validate if the adb executable is
avaliable
Formatted README.md to 80 characters per line
@edgan edgan changed the title Changed execute_adb_command to explicitly use adb as a prefix Changed execute_adb_command to explicitly use adb as a prefix and improved README.md Mar 24, 2025
@minhalvp
Copy link
Owner

Your first 3 commits makes sense and I would like to merge.
#4 Adding adb as a prefix would change nothing as it is removed again in execute_adb_command in adbdevicemanager.py. I think I need to change the function names to make it more obvious that it is specifically an adb shell command that is being executed by the function

@minhalvp
Copy link
Owner

I merged the first 3 commits. I provided a response about the 4th commit in #3

@edgan edgan closed this Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants