Skip to content

Include libspelling, flatpak-rpm-macros and flatpak-runtime-config packages #1355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tpopela
Copy link
Contributor

@tpopela tpopela commented Jan 22, 2025

See individual commits

Used by GNOME Text Editor and Papers and currently being added into RHEL
10
Comment on lines +12 to +13
- flatpak-rpm-macros
- flatpak-runtime-config
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

buildroot only? If so, maybe move these to the end of the list and precede with a comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, they're shipped in CRB.

@yselkowitz
Copy link
Collaborator

How is this going to work for ELN though? The rawhide branch of flatpak-runtime-config was retired as "modular only" (this was prior to my involvement with flatpaks, and while they were still actually modular). Does this mean we need to unretire the rawhide branch and start building it there too? (Without doing so, the package is blocked, so it can't even be built manually into ELN.)

Also, are you planning on shipping flatpak-container-tools in CRB?

@tpopela
Copy link
Contributor Author

tpopela commented Jan 23, 2025

How is this going to work for ELN though? The rawhide branch of flatpak-runtime-config was retired as "modular only" (this was prior to my involvement with flatpaks, and while they were still actually modular). Does this mean we need to unretire the rawhide branch and start building it there too? (Without doing so, the package is blocked, so it can't even be built manually into ELN.)

That's a good question that I don't know the answer for - will have to check with Owen, but the package is still included in RHEL 10's Runtime and SDK.

Also, are you planning on shipping flatpak-container-tools in CRB?

AFAIK No. We were not shipping even the flatpak-module-tools.

@owtaylor
Copy link

How is this going to work for ELN though? The rawhide branch of flatpak-runtime-config was retired as "modular only" (this was prior to my involvement with flatpaks, and while they were still actually modular). Does this mean we need to unretire the rawhide branch and start building it there too? (Without doing so, the package is blocked, so it can't even be built manually into ELN.)

As you know, flatpak-runtime-config and flatpak-rpm-macros ares currently built manually into the f-flatpak-runtime tag - there's no particular reason that they couldn't be built into the main tags instead - they have some potential to make things weird if a user if a installs them accidentally, but I'm sure there are other packages like that in Fedora. Would that make things simpler?

Also, are you planning on shipping flatpak-container-tools in CRB?

AFAIK No. We were not shipping even the flatpak-module-tools.

I think the way we'd want a RHEL customer to consume flatpak-container-tools is via https://quay.io/repository/flatpak-container/flatpak-build - if there's customer demand we'd look at making that an official Red Hat container rather than shipping flatpak-container-tools in CRB - the flatpak-container-tools CLI is basically only useful in the context of Koji.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants