Skip to content

Small change to functional test, check FULL_OBJECT mode is returned properly #2138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Small change to functional test, check FULL_OBJECT mode is returned properly #2138

wants to merge 1 commit into from

Conversation

marktheunissen
Copy link
Contributor

No description provided.

@marktheunissen
Copy link
Contributor Author

This test currently fails against AIStor with:

panic: Test failed with message: Checksum mode is not full object, err: got COMPOSITE, want FULL_OBJECT

@klauspost
Copy link
Contributor

klauspost commented Jul 23, 2025 •
edited
Loading

Try with changing https://github.com/miniohq/eos/blob/cec5ad6ad89a713dbeb445c11498613203e86a1c/internal/hash/checksum.go#L232

to if c.IsSet() && c.FullObjectRequested() || !c.Is(ChecksumMultipart) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marktheunissen @klauspost