feat: explicitly define logger #1427
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dear future minio-js maintainers: DO NOT USE CONSOLE AT ALL. It's painful to debug why a certain log suddenly pop up without a sensible message explaining (1) where the log came from, and (2) what caused this log to show up. With exposing the logger as an interface to the users, they can create a prefix or identifier that this log is coming from the MinIO JS SDK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear future minio-js maintainers: DO NOT USE CONSOLE AT ALL. It's painful to debug why a certain log suddenly pop up without a sensible message explaining (1) where the log came from, and (2) what caused this log to show up.
With exposing the logger as an interface to the users, they can create a prefix or identifier that this log is coming from the MinIO JS SDK.
This will definitely conflict with #1426, so please merge #1426 first.