Small fixes

minkphp · Jun 10, 2023 · d871598 · d871598
1 parent 7373d71
commit d871598
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 6 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -48,6 +48,7 @@ jobs:
           php-version: "${{ matrix.php }}"
           tools: composer
           ini-file: development
+          ini-values: date.timezone=Europe/Berlin, error_reporting=-1, display_errors=On
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
@@ -60,9 +61,12 @@ jobs:
           curl --head -X GET --silent --show-error --retry 60 --retry-connrefused --retry-delay 1 http://172.18.0.2:4444
 
       - name: Run tests
+        env:
+          WEB_FIXTURES_BROWSER: ${{ matrix.browser }}
+          DRIVER_URL: http://172.18.0.2:4444/wd/hub
+          WEB_FIXTURES_HOST: http://host.docker.internal:8002
+          DRIVER_MACHINE_BASE_PATH: /fixtures/
         run: |
-          export WEB_FIXTURES_BROWSER=${{ matrix.browser }}
-          export DRIVER_URL=http://172.18.0.2:4444/wd/hub
           vendor/bin/phpunit -v --coverage-clover=coverage.xml --colors=always --testdox
 
       - name: Upload coverage

diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -1,7 +1,8 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
          xsi:noNamespaceSchemaLocation="vendor/phpunit/phpunit/phpunit.xsd"
-         bootstrap="tests/bootstrap.local-docker.php"
+         bootstrap="tests/bootstrap.php"
+         beStrictAboutOutputDuringTests="true"
          colors="true">
     <coverage>
         <include>
@@ -17,17 +18,19 @@
     </testsuites>
 
     <php>
-        <env name="SYMFONY_DEPRECATIONS_HELPER" value="disabled" />
         <var name="driver_config_factory" value="Mink\WebdriverClassDriver\Tests\WebdriverClassicConfig::getInstance"/>
+
         <server name="WEB_FIXTURES_HOST" value="http://host.docker.internal:8002"/>
         <!-- MacOS -->
         <!--<server name="WEB_FIXTURES_HOST" value="http://docker.for.mac.localhost:8002"/>-->
-        <!--<server name="WEB_FIXTURES_BROWSER" value="firefox"/>-->
+
         <!-- where driver will connect to -->
         <server name="DRIVER_URL" value="http://localhost:4444/wd/hub"/>
+
         <!-- where DocumentRoot of 'Test Machine' is mounted to on 'Driver Machine' (only if these are 2 different machines) -->
-        <!--server name="DRIVER_MACHINE_BASE_PATH" value="" /-->
         <server name="DRIVER_MACHINE_BASE_PATH" value="/fixtures/"/>
+
+        <env name="SYMFONY_DEPRECATIONS_HELPER" value="disabled" />
     </php>
 
     <listeners>