Upgrade phpstan; increase phpstan level; fix a few bugs #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
uuf6429
commented
Jan 1, 2025
•
uuf6429
commented
-
⚠️ Must be rebased on main after Increase PHPStan level to 9 #58 is merged.
uuf6429
force-pushed
the
chore/upgrade-phpstan
branch
from
4f4011a to
632a083
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## chore/increase-phpstan-level #55 +/- ##
==================================================================
+ Coverage 87.59% 87.74% +0.14%
+ Complexity 198 197 -1
==================================================================
Files 1 1
Lines 508 506 -2
==================================================================
- Hits 445 444 -1
+ Misses 63 62 -1 ☔ View full report in Codecov by Sentry. |
uuf6429
force-pushed
the
chore/upgrade-phpstan
branch
from
632a083 to
40df2cc
Compare
uuf6429
commented
Jan 1, 2025
uuf6429
commented
Jan 1, 2025
aik099
requested changes
Jan 1, 2025
aik099
approved these changes
Jan 1, 2025
uuf6429
commented
Jan 1, 2025
uuf6429
commented
Jan 1, 2025
uuf6429
commented
Jan 1, 2025
aik099
requested changes
Jan 2, 2025
aik099
requested changes
Jan 3, 2025
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
uuf6429
force-pushed
the
chore/upgrade-phpstan
branch
from
cf73ed0 to
8d7197e
Compare
uuf6429
changed the base branch from
chore/fix-phpstan-warnings
to
chore/increase-phpstan-level
uuf6429
force-pushed
the
chore/upgrade-phpstan
branch
from
8d7197e to
0d74697
Compare
uuf6429
force-pushed
the
chore/upgrade-phpstan
branch
from
0d74697 to
602aa24
Compare
1 task
aik099
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.