Repository navigation
fix: resolve issues #135-#146 and harden tools/core - #149
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Apply and validate all fixes requested in issues #135 through #146.
Summary
data:support fromwebfetch(fix: Remove data: protocol from webfetch tool to prevent security risks #135)shellargv quoting semantics (fix: Review shellJoin regex for potentially dangerous characters #138)apply_patchsymlink escape viarealpathchecks (fix: Prevent apply_patch sandbox escape via symlink targets #143)accumulateUsagetotal computation expression (fix: Correct operator precedence in accumulateUsage function #136)JsonlHistorySink.close()+ serialized write queue; wire close path in session runtime (fix: Add close method and fix race condition in JsonlHistorySink #137)emitEventToSinksfailure path (fix: Replace console.error with structured logging in emitEventToSinks #140)stableStringify(fix: Add circular reference handling to stableStringify function #142)parseToolInput(fix: Add size limits and improve type safety in parseToolInput #139)max_output_tokenstruncation boundaries (fix: Preserve unread exec output when max_output_tokens truncates a chunk #144)timeout_msenforce execution deadline for shell wrappers (fix: Enforce timeout_ms in shell and shell_command to prevent orphan processes #145)MAX_SESSIONS) (fix: Enforce active session cap in UnifiedExecManager #146)Validation
pnpm run test:corepnpm run test:toolsBoth suites pass locally.