Use new headless parameters for testing in Chrome.

mint-lang · Jan 22, 2025 · b420fa7 · b420fa7
1 parent e471127
commit b420fa7
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/.github/workflows/ci-base.yml b/.github/workflows/ci-base.yml
@@ -15,6 +15,7 @@ jobs:
       matrix:
         os: [ubuntu-latest, macos-13]
     runs-on: ${{ matrix.os }}
+    timeout-minutes: 15
 
     steps:
       - name: Install Crystal
@@ -42,8 +43,6 @@ jobs:
 
       - name: Run CLI specs
         run: crystal spec spec_cli/*_spec.cr spec_cli/**/*_spec.cr --error-on-warnings --error-trace
-        continue-on-error: true
-        timeout-minutes: 2
 
       - name: Run core specs (Firefox)
         working-directory: ./core/tests

diff --git a/spec_cli/test_spec.cr b/spec_cli/test_spec.cr
@@ -38,7 +38,7 @@ context "test" do
       TEXT
   end
 
-  pending "runs the tests" do
+  it "runs the tests" do
     expect_output ["test"], clear_env: false, template: <<-TEXT
       Mint - Running tests
       ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

diff --git a/src/test_runner/browser.cr b/src/test_runner/browser.cr
@@ -102,11 +102,10 @@ module Mint
           ])
         when "chrome"
           Process.new(@path, args: [
-            "--profile-directory=#{profile_directory}",
-            "--remote-debugging-port=9222",
+            "--user-data-dir=#{profile_directory}",
             "--window-size=1920,1080",
-            "--headless=old",
             "--disable-gpu",
+            "--headless",
             url,
           ])
         else