Skip to content

🎨 Modernize test harness #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pboling
Copy link

@pboling pboling commented Oct 25, 2023

The test suite continues to not work at all, due to:

  1) JsonValidator validate_each with valid JSON data but schema errors 
     Failure/Error:
       create_table(:users, force: true) do |t|
         t.text :data
         t.json :smart_data
       end
     
     NoMethodError:
       undefined method `level' for false:FalseClass
     # ./spec/json_validator_spec.rb:22:in `block (4 levels) in <top (required)>'
     # ./spec/support/macros/database_macros.rb:16:in `instance_exec'
     # ./spec/support/macros/database_macros.rb:16:in `block in run_migration'
     # ./spec/support/macros/database_macros.rb:19:in `run_migration'
     # ./spec/json_validator_spec.rb:21:in `block (3 levels) in <top (required)>'

It is the same error with both MySQL and PostgreSQL drivers.

But this is a big step in the direction of getting it working again.

I'm hoping this is step one on a path to getting the gem working with json_schemer v2!

@pboling pboling force-pushed the modernize-test-harness branch from a002eb6 to 638f00a Compare October 25, 2023 01:37
@remi
Copy link
Member

remi commented Oct 27, 2023

Hi Peter!

Could you fix the Rubocop errors so that the workflow can fail when running the test suite? 😬 Sorry about that!

@pboling pboling force-pushed the modernize-test-harness branch from 638f00a to f7d0955 Compare October 27, 2023 02:06
@pboling
Copy link
Author

pboling commented Oct 27, 2023

@remi Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants