Skip to content

Support nil image size in PilotRemoteImageView #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
npresseault merged 1 commit into from
Jul 14, 2025
Merged

Support nil image size in PilotRemoteImageView #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions components/ios/kingfisher/PilotRemoteImageView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ public struct PilotRemoteImageView: View {

private enum Content {
case normal(PilotRemoteImage)
case resizable(PilotResizableRemoteImage, CGSize)
case resizable(PilotResizableRemoteImage, CGSize?)
}

private var imageConfigurations = [ImageConfiguration]()
Expand All @@ -24,7 +24,7 @@ public struct PilotRemoteImageView: View {
self.content = .normal(content)
}

public init(_ content: PilotResizableRemoteImage, size: CGSize) {
public init(_ content: PilotResizableRemoteImage, size: CGSize?) {
self.content = .resizable(content, size)
}

Expand Down Expand Up @@ -59,12 +59,16 @@ public struct PilotRemoteImageView: View {
case .normal(let pilotRemoteImage):
stringToURL(pilotRemoteImage.url)
case let .resizable(pilotResizableRemoteImage, size):
stringToURL(
pilotResizableRemoteImage.url(
width: KotlinInt(int: Int32(size.width * displayScale)),
height: KotlinInt(int: Int32(size.height * displayScale))
if let size {
stringToURL(
pilotResizableRemoteImage.url(
width: KotlinInt(int: Int32(size.width * displayScale)),
height: KotlinInt(int: Int32(size.height * displayScale))
)
)
)
} else {
nil
}
}
}

Expand Down
Loading