[Components] Changed the width of the compose PilotTextField placeholder view to fillMaxWidth#33
Merged
Merged
Conversation
…der view to fillMaxWidth
nlangheit
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The placeholder view used by the
PilotTextFieldis aTextwrapping its width. This was a limitation to get a proper centered textfield.The proper way to have a centered textfield is to use the text style
textAlign. With that field set, the text field text is properly centered, no matter the width of the viewHowever, it was not possible to get the same behavior for the placeholder, since even when setting its
textAlignvalue, it would still be aligned to the left. TheTextcontent would be centered (but since it wraps its content, it has no effect), but theTextwould still be left aligned in its parent.Setting the placeholder to be as wide as the TextField allows us to have the same behavior for both the actual textField and the placeholder, since they share the same width.
The default behavior remains unchanged, since
textAligndefault value isstarton text styles.