Skip to content

Features/add enabled controls #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
G-lalonde merged 2 commits into from
May 4, 2026
Merged

Features/add enabled controls #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d041868
Add isEnabled to pilot switch
G-lalonde May 4, 2026
af6b8cc
add is enabled on picker and textfield
G-lalonde May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...android/material3/src/main/kotlin/com/mirego/pilot/components/ui/material3/PilotPicker.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,12 @@ public fun <LABEL : Any, ITEM : Any> PilotPicker(
labelView: @Composable (label: LABEL) -> Unit,
item: @Composable (item: ITEM) -> Unit,
) {
val isEnabled by pilotPicker.isEnabled.collectAsState()
Box {
Box(
modifier = modifier
.clickable(
enabled = isEnabled,
onClick = { onExpandedChange(!expanded) },
role = Role.DropdownList,
),
Expand Down
3 changes: 2 additions & 1 deletion ...roid/material3/src/main/kotlin/com/mirego/pilot/components/ui/material3/PilotTextField.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ public fun PilotTextField(
) {
val textValue by pilotTextField.text.collectAsState()
val placeHolder by pilotTextField.placeholder.collectAsState()
val isEnabledFlow by pilotTextField.isEnabled.collectAsState()
val autoCapitalization by pilotTextField.autoCapitalization.collectAsState()
val autoCorrect by pilotTextField.autoCorrect.collectAsState()
val keyboardType by pilotTextField.keyboardType.collectAsState()
Expand Down Expand Up @@ -100,7 +101,7 @@ public fun PilotTextField(
interactionSource = interactionSource,
shape = shape,
colors = colors,
enabled = enabled,
enabled = enabled && isEnabledFlow,

@G-lalonde G-lalonde May 4, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PilotTextField alreayd has an enabled: Boolean = true parameter in its constructor. I kept both for now to avoid breaking changes and allow transition to drive this value only from the common.

readOnly = readOnly,
singleLine = singleLine,
)
Expand Down
52 changes: 28 additions & 24 deletions components/common/api/components.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,14 @@ public abstract interface class com/mirego/pilot/components/PilotImageResource {
public abstract fun getName ()Ljava/lang/String;
}

public final class com/mirego/pilot/components/PilotPicker {
public class com/mirego/pilot/components/PilotPicker {
public static final field $stable I
public fun <init> (Lkotlinx/coroutines/flow/StateFlow;Lkotlinx/coroutines/flow/StateFlow;Lkotlin/jvm/functions/Function1;)V
public final fun getItems ()Lkotlinx/coroutines/flow/StateFlow;
public final fun getLabel ()Lkotlinx/coroutines/flow/StateFlow;
public final fun getOnSelectedIndex ()Lkotlin/jvm/functions/Function1;
public fun <init> (Lkotlinx/coroutines/flow/StateFlow;Lkotlinx/coroutines/flow/StateFlow;Lkotlinx/coroutines/flow/StateFlow;Lkotlin/jvm/functions/Function1;)V
public synthetic fun <init> (Lkotlinx/coroutines/flow/StateFlow;Lkotlinx/coroutines/flow/StateFlow;Lkotlinx/coroutines/flow/StateFlow;Lkotlin/jvm/functions/Function1;ILkotlin/jvm/internal/DefaultConstructorMarker;)V
public fun getItems ()Lkotlinx/coroutines/flow/StateFlow;
public fun getLabel ()Lkotlinx/coroutines/flow/StateFlow;
public fun getOnSelectedIndex ()Lkotlin/jvm/functions/Function1;
public fun isEnabled ()Lkotlinx/coroutines/flow/StateFlow;
}

public final class com/mirego/pilot/components/PilotRemoteImage {
Expand Down Expand Up @@ -154,31 +156,33 @@ public final class com/mirego/pilot/components/PilotRichTextSpan$Style : com/mir
public fun toString ()Ljava/lang/String;
}

public final class com/mirego/pilot/components/PilotSwitch {
public class com/mirego/pilot/components/PilotSwitch {
public static final field $stable I
public fun <init> (Lkotlinx/coroutines/flow/StateFlow;Ljava/lang/Object;Lkotlin/jvm/functions/Function1;)V
public synthetic fun <init> (Lkotlinx/coroutines/flow/StateFlow;Ljava/lang/Object;Lkotlin/jvm/functions/Function1;ILkotlin/jvm/internal/DefaultConstructorMarker;)V
public final fun getLabel ()Ljava/lang/Object;
public final fun getOnCheckedChange ()Lkotlin/jvm/functions/Function1;
public final fun isOn ()Lkotlinx/coroutines/flow/StateFlow;
public fun <init> (Lkotlinx/coroutines/flow/StateFlow;Ljava/lang/Object;Lkotlinx/coroutines/flow/StateFlow;Lkotlin/jvm/functions/Function1;)V
public synthetic fun <init> (Lkotlinx/coroutines/flow/StateFlow;Ljava/lang/Object;Lkotlinx/coroutines/flow/StateFlow;Lkotlin/jvm/functions/Function1;ILkotlin/jvm/internal/DefaultConstructorMarker;)V
public fun getLabel ()Ljava/lang/Object;
public fun getOnCheckedChange ()Lkotlin/jvm/functions/Function1;
public fun isEnabled ()Lkotlinx/coroutines/flow/StateFlow;
public fun isOn ()Lkotlinx/coroutines/flow/StateFlow;
}

public class com/mirego/pilot/components/PilotTextField {
public static final field $stable I
public fun <init> (Lkotlinx/coroutines/flow/MutableStateFlow;Lkotlinx/coroutines/flow/StateFlow;Lkotlinx/coroutines/flow/StateFlow;Lkotlinx/coroutines/flow/StateFlow;Lkotlinx/coroutines/flow/StateFlow;Lkotlinx/coroutines/flow/StateFlow;Lkotlinx/coroutines/flow/StateFlow;Lkotlinx/coroutines/flow/StateFlow;Lkotlin/jvm/functions/Function0;Lkotlin/jvm/functions/Function1;Lkotlin/jvm/functions/Function1;Lkotlin/jvm/functions/Function1;)V
public synthetic fun <init> (Lkotlinx/coroutines/flow/MutableStateFlow;Lkotlinx/coroutines/flow/StateFlow;Lkotlinx/coroutines/flow/StateFlow;Lkotlinx/coroutines/flow/StateFlow;Lkotlinx/coroutines/flow/StateFlow;Lkotlinx/coroutines/flow/StateFlow;Lkotlinx/coroutines/flow/StateFlow;Lkotlinx/coroutines/flow/StateFlow;Lkotlin/jvm/functions/Function0;Lkotlin/jvm/functions/Function1;Lkotlin/jvm/functions/Function1;Lkotlin/jvm/functions/Function1;ILkotlin/jvm/internal/DefaultConstructorMarker;)V
public final fun getAutoCapitalization ()Lkotlinx/coroutines/flow/StateFlow;
public final fun getAutoCorrect ()Lkotlinx/coroutines/flow/StateFlow;
public final fun getContentType ()Lkotlinx/coroutines/flow/StateFlow;
public final fun getFormatText ()Lkotlin/jvm/functions/Function1;
public final fun getKeyboardReturnKeyType ()Lkotlinx/coroutines/flow/StateFlow;
public final fun getKeyboardType ()Lkotlinx/coroutines/flow/StateFlow;
public final fun getOnReturnKeyTap ()Lkotlin/jvm/functions/Function0;
public final fun getPlaceholder ()Lkotlinx/coroutines/flow/StateFlow;
public fun <init> (Lkotlinx/coroutines/flow/MutableStateFlow;Lkotlinx/coroutines/flow/StateFlow;Lkotlinx/coroutines/flow/StateFlow;Lkotlinx/coroutines/flow/StateFlow;Lkotlinx/coroutines/flow/StateFlow;Lkotlinx/coroutines/flow/StateFlow;Lkotlinx/coroutines/flow/StateFlow;Lkotlinx/coroutines/flow/StateFlow;Lkotlinx/coroutines/flow/StateFlow;Lkotlin/jvm/functions/Function0;Lkotlin/jvm/functions/Function1;Lkotlin/jvm/functions/Function1;Lkotlin/jvm/functions/Function1;)V
public synthetic fun <init> (Lkotlinx/coroutines/flow/MutableStateFlow;Lkotlinx/coroutines/flow/StateFlow;Lkotlinx/coroutines/flow/StateFlow;Lkotlinx/coroutines/flow/StateFlow;Lkotlinx/coroutines/flow/StateFlow;Lkotlinx/coroutines/flow/StateFlow;Lkotlinx/coroutines/flow/StateFlow;Lkotlinx/coroutines/flow/StateFlow;Lkotlinx/coroutines/flow/StateFlow;Lkotlin/jvm/functions/Function0;Lkotlin/jvm/functions/Function1;Lkotlin/jvm/functions/Function1;Lkotlin/jvm/functions/Function1;ILkotlin/jvm/internal/DefaultConstructorMarker;)V
public fun getAutoCapitalization ()Lkotlinx/coroutines/flow/StateFlow;
public fun getAutoCorrect ()Lkotlinx/coroutines/flow/StateFlow;
public fun getContentType ()Lkotlinx/coroutines/flow/StateFlow;
public fun getFormatText ()Lkotlin/jvm/functions/Function1;
public fun getKeyboardReturnKeyType ()Lkotlinx/coroutines/flow/StateFlow;
public fun getKeyboardType ()Lkotlinx/coroutines/flow/StateFlow;
public fun getOnReturnKeyTap ()Lkotlin/jvm/functions/Function0;
public fun getPlaceholder ()Lkotlinx/coroutines/flow/StateFlow;
public final fun getText ()Lkotlinx/coroutines/flow/StateFlow;
public final fun getTextObfuscationMode ()Lkotlinx/coroutines/flow/StateFlow;
public final fun getTransformText ()Lkotlin/jvm/functions/Function1;
public final fun getUnformatText ()Lkotlin/jvm/functions/Function1;
public fun getTextObfuscationMode ()Lkotlinx/coroutines/flow/StateFlow;
public fun getTransformText ()Lkotlin/jvm/functions/Function1;
public fun getUnformatText ()Lkotlin/jvm/functions/Function1;
public fun isEnabled ()Lkotlinx/coroutines/flow/StateFlow;
public final fun onValueChange (Ljava/lang/String;)V
}

Expand Down
10 changes: 6 additions & 4 deletions components/common/src/commonMain/kotlin/com/mirego/pilot/components/PilotPicker.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
package com.mirego.pilot.components

import kotlinx.coroutines.flow.MutableStateFlow
import kotlinx.coroutines.flow.StateFlow

public class PilotPicker<LABEL : Any, ITEM : Any>(
public val label: StateFlow<LABEL>,
public val items: StateFlow<List<ITEM>>,
public val onSelectedIndex: (Int) -> Unit,
public open class PilotPicker<LABEL : Any, ITEM : Any>(
public open val label: StateFlow<LABEL>,
public open val items: StateFlow<List<ITEM>>,
public open val isEnabled: StateFlow<Boolean> = MutableStateFlow(true),
public open val onSelectedIndex: (Int) -> Unit,
)
10 changes: 6 additions & 4 deletions components/common/src/commonMain/kotlin/com/mirego/pilot/components/PilotSwitch.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
package com.mirego.pilot.components

import kotlinx.coroutines.flow.MutableStateFlow
import kotlinx.coroutines.flow.StateFlow

public class PilotSwitch<T : Any>(
public val isOn: StateFlow<Boolean>,
public val label: T,
public val onCheckedChange: (Boolean) -> Unit = {},
public open class PilotSwitch<T : Any>(
public open val isOn: StateFlow<Boolean>,
public open val label: T,
public open val isEnabled: StateFlow<Boolean> = MutableStateFlow(true),
public open val onCheckedChange: (Boolean) -> Unit = {},
)
23 changes: 12 additions & 11 deletions components/common/src/commonMain/kotlin/com/mirego/pilot/components/PilotTextField.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,18 @@ import kotlinx.coroutines.flow.StateFlow

public open class PilotTextField(
private val textFlow: MutableStateFlow<String>,
public val placeholder: StateFlow<String>,
public val keyboardType: StateFlow<PilotKeyboardType> = MutableStateFlow(PilotKeyboardType.Default),
public val keyboardReturnKeyType: StateFlow<PilotKeyboardReturnKeyType> = MutableStateFlow(PilotKeyboardReturnKeyType.Default),
public val contentType: StateFlow<PilotTextContentType> = MutableStateFlow(PilotTextContentType.NotSet),
public val textObfuscationMode: StateFlow<PilotTextObfuscationMode> = MutableStateFlow(PilotTextObfuscationMode.Visible),
public val autoCorrect: StateFlow<Boolean> = MutableStateFlow(true),
public val autoCapitalization: StateFlow<PilotKeyboardAutoCapitalization> = MutableStateFlow(PilotKeyboardAutoCapitalization.Sentences),
public val onReturnKeyTap: () -> Unit = {},
public val formatText: (text: String) -> String = { it },
public val unformatText: (text: String) -> String = { it },
public val transformText: (text: String) -> String = { it },
public open val placeholder: StateFlow<String>,
public open val isEnabled: StateFlow<Boolean> = MutableStateFlow(true),
public open val keyboardType: StateFlow<PilotKeyboardType> = MutableStateFlow(PilotKeyboardType.Default),
public open val keyboardReturnKeyType: StateFlow<PilotKeyboardReturnKeyType> = MutableStateFlow(PilotKeyboardReturnKeyType.Default),
public open val contentType: StateFlow<PilotTextContentType> = MutableStateFlow(PilotTextContentType.NotSet),
public open val textObfuscationMode: StateFlow<PilotTextObfuscationMode> = MutableStateFlow(PilotTextObfuscationMode.Visible),
public open val autoCorrect: StateFlow<Boolean> = MutableStateFlow(true),
public open val autoCapitalization: StateFlow<PilotKeyboardAutoCapitalization> = MutableStateFlow(PilotKeyboardAutoCapitalization.Sentences),
public open val onReturnKeyTap: () -> Unit = {},
public open val formatText: (text: String) -> String = { it },
public open val unformatText: (text: String) -> String = { it },
public open val transformText: (text: String) -> String = { it },
) {

public val text: StateFlow<String> = textFlow
Expand Down
3 changes: 3 additions & 0 deletions components/ios/base/PilotPickerView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ public struct PilotPickerView<Label, LabelView, Item, ItemView>: View where Labe

@ObservedObject private var label: StateObservable<Label>
@ObservedObject private var items: StateObservable<[Item]>
@ObservedObject private var isEnabled: StateObservable<KotlinBoolean>

public init(
_ picker: PilotPicker<Label, Item>,
Expand All @@ -21,6 +22,7 @@ public struct PilotPickerView<Label, LabelView, Item, ItemView>: View where Labe

_label = ObservedObject(wrappedValue: StateObservable(picker.label))
_items = ObservedObject(wrappedValue: StateObservable(picker.items))
_isEnabled = ObservedObject(wrappedValue: StateObservable(picker.isEnabled))
}

public var body: some View {
Expand All @@ -35,5 +37,6 @@ public struct PilotPickerView<Label, LabelView, Item, ItemView>: View where Labe
} label: {
labelBuilder(label.value)
}
.disabled(!isEnabled.value.boolValue)
}
}
3 changes: 3 additions & 0 deletions components/ios/base/PilotSwitchView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,13 @@ public struct PilotSwitchView<Content, Label>: View where Content: AnyObject, La
private let labelBuilder: (Content) -> Label

@ObservedObject private var isOn: StateObservable<KotlinBoolean>
@ObservedObject private var isEnabled: StateObservable<KotlinBoolean>

public init(_ pilotSwitch: PilotSwitch<Content>, labelBuilder: @escaping (Content) -> Label) {
self.pilotSwitch = pilotSwitch
self.labelBuilder = labelBuilder
_isOn = ObservedObject(wrappedValue: StateObservable(pilotSwitch.isOn))
_isEnabled = ObservedObject(wrappedValue: StateObservable(pilotSwitch.isEnabled))
}

public var body: some View {
Expand All @@ -25,5 +27,6 @@ public struct PilotSwitchView<Content, Label>: View where Content: AnyObject, La
) {
labelBuilder(pilotSwitch.label)
}
.disabled(!isEnabled.value.boolValue)
}
}
3 changes: 3 additions & 0 deletions components/ios/base/PilotTextFieldView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ public struct PilotTextFieldView<Label>: View where Label: View {

@ObservedObject private var text: StateObservable<String>
@ObservedObject private var placeholder: StateObservable<String>
@ObservedObject private var isEnabled: StateObservable<KotlinBoolean>
@ObservedObject private var keyboardType: StateObservable<PilotKeyboardType>
@ObservedObject private var keyboardReturnKeyType: StateObservable<PilotKeyboardReturnKeyType>
@ObservedObject private var contentType: StateObservable<PilotTextContentType>
Expand All @@ -28,6 +29,7 @@ public struct PilotTextFieldView<Label>: View where Label: View {

_text = ObservedObject(wrappedValue: StateObservable(pilotTextField.text))
_placeholder = ObservedObject(wrappedValue: StateObservable(pilotTextField.placeholder))
_isEnabled = ObservedObject(wrappedValue: StateObservable(pilotTextField.isEnabled))
_keyboardType = ObservedObject(wrappedValue: StateObservable(pilotTextField.keyboardType))
_keyboardReturnKeyType = ObservedObject(wrappedValue: StateObservable(pilotTextField.keyboardReturnKeyType))
_contentType = ObservedObject(wrappedValue: StateObservable(pilotTextField.contentType))
Expand All @@ -50,6 +52,7 @@ public struct PilotTextFieldView<Label>: View where Label: View {
.textContentType(contentType.value.uiTextContentType)
#endif
.disableAutocorrection(!autoCorrect.value.boolValue)
.disabled(!isEnabled.value.boolValue)
.textFieldStyle(ExtendedTapAreaTextFieldStyle())
.onChange(of: text.value) { newValue in
textFieldText = pilotTextField.formatText(newValue)
Expand Down
Loading