fix(skills): allow dots in skill names for cross-platform compatibility#868
Open
abhay-codes07 wants to merge 1 commit into
Open
fix(skills): allow dots in skill names for cross-platform compatibility#868abhay-codes07 wants to merge 1 commit into
abhay-codes07 wants to merge 1 commit into
Conversation
Skill directories named with dot namespacing (for example ama.accounting.mailbox.vendor-receipts) load fine in other agent CLIs but fail Vibe's name validation, which only allowed lowercase alphanumerics and hyphens. Relax the pattern to accept dots as an additional separator while still rejecting leading, trailing, and consecutive separators. Fixes mistralai#867
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #867
Skill directories that use dot namespacing (like
ama.accounting.mailbox.vendor-receipts) work in other agent CLIs but fail Vibe's skill name validation, which only allowed lowercase alphanumerics separated by hyphens. Anyone sharing skills across tools has to rename their directories just for Vibe.This relaxes the
SkillMetadata.namepattern to also accept dots as separators:^[a-z0-9]+([-.][a-z0-9]+)*$. Leading, trailing and consecutive separators are still rejected, and everything that was valid before stays valid. The registry name sanitizer already produces names that satisfy the old pattern, so nothing else needed to change.Testing:
@elGrogz would appreciate a look when you get a chance, this one keeps coming up for people moving skills between tools.