fix(session-picker): avoid MissingStyle when confirming session delete#908
Open
syf2211 wants to merge 2 commits into
Open
fix(session-picker): avoid MissingStyle when confirming session delete#908syf2211 wants to merge 2 commits into
syf2211 wants to merge 2 commits into
Conversation
OptionList renders option prompts via Content.from_rich_text, which cannot parse the Textual theme token $primary in Rich style spans. Building the delete confirmation prompt with Content.from_markup avoids MissingStyle when pressing 'd' to delete a session. Fixes mistralai#907
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a crash when pressing
dto delete a session in the session picker. The delete confirmation prompt now uses Textual markup (Content.from_markup) instead of RichText.appendwith$primarytheme tokens.Motivation
OptionListrenders option prompts viaContent.from_rich_text, which cannot parse Textual theme variables like$primary. The delete confirmation path usedtext.append("d", style=SHORTCUT_STYLE)whereSHORTCUT_STYLE = "b not dim $primary", causing:Reported in #907.
Changes
Content.from_markupandshortcut('d'), matching the pattern used in help text andquit_manager.py_option_text/_show_delete_stateprompt types toText | ContentOptionList._update_lines()with the confirmation promptTests
python3 -m pytest tests/cli/textual_ui/test_session_picker.py -q -o addopts=""Result: 33 passed
Notes
Textwithout$primaryFixes #907