Add minitest to gemspec, fix deprecation warnings#4
Open
dsander wants to merge 1 commit intomistydemeo:masterfrom
Open
Add minitest to gemspec, fix deprecation warnings#4dsander wants to merge 1 commit intomistydemeo:masterfrom
dsander wants to merge 1 commit intomistydemeo:masterfrom
Conversation
Without minitest in the gemspec running `rake test` failed with `test/dataconverter_test.rb:3:in `require': cannot load such file -- minitest/autorun`.
After installing the current version it complained about deprecation
warnings:
```
DEPRECATED: global use of must_equal from /Users/dominik/code/ruby/exempi/test/datetime_test.rb:17. Use _(obj).must_equal instead. This will fail in Minitest 6.
DEPRECATED: global use of must_raise from /Users/dominik/code/ruby/exempi/test/dataconverter_test.rb:24. Use _{obj.method}.must_raise instead. This will fail in Minitest 6.
```
This addresses both problems.
Owner
|
I'll give this a test soon, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello again 😄
Without minitest in the gemspec running
rake testfailed withtest/dataconverter_test.rb:3:inrequire': cannot load such file -- minitest/autorun`.After installing the current version it complained about deprecation warnings:
This addresses both problems.