This repository has been archived by the owner on Oct 16, 2019. It is now read-only.
add the devices section to the domain specification #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Mitchell, I just added the devices section to the spec, there are still some missing sections under devices but it's mostly complete.
I'm getting a convention that I think we should follow, any primary element that requires an attribute gets it from the constructor, for instance the disk specification takes the type as mandatory parameter:
<disk type='file'>...</disk>
Libvirt::Spec::Disk.new('file')
I've also seen that we don't have any test on the spec, I'll try to add some basic ones this weekend.