-
Notifications
You must be signed in to change notification settings - Fork 6
add fields to program summary report to allow for additional filtering of the report #1559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I didn't get to it last week. The dbt run successfully. However, when I check the data, the program_type, program_track and program_readable_id are all NULL for edX.org, which doesn't seem correct.
The initial design for program_summary_report was to group all the variants into one (see the original issue - To keep the summary simple, we will summarize all these variants as one program). This is why the program_track was not included in the report. @pdpinch is this requirement changed?
However, the current logic appears to be grouping by both program_readable_id, program_type and program_track, which should create separate rows for each variant. That is fine as long as the grouping is intentional, but for the program Statistics and Data Science, the summary should not be a single row now because it has 4 variants (4 program tracks). Here is the dashboard for "Statistics and Data Science" in https://bi.ol.mit.edu/superset/dashboard/p/ed9qrbjqxan/ for comparison.
@KatelynGit Can you please take a look?
Thanks for taking a look Rachel. I'll look into it. Just to give background- the reason for this request was really driven by Jeremy Rossen and others looking as SDS program data and were trying to use the filters on the left hand side of the dashboard here- https://bi.ol.mit.edu/superset/dashboard/p/vmQq1YwqAdJ/ they noticed the filters weren't working for the summary tab and needed them to answer some of their questions. |
Good to know. https://github.com/mitodl/hq/issues/6124#issuecomment-2546322904 - this is where we left when Peter noticed the same thing, so I can understand the confusion - it wasn't designed to filter by program type, only by name. |
|
@KatelynGit is this still relevant? |
It would still be a good change i think- but not urgent |
What are the relevant tickets?
https://github.mit.edu/MIT-OL-Data-Platform/Data-Platform-Issues/issues/4
Description (What does it do?)
adds platform, program_type, program_track, and program_readable_id fields to the program_summary_report
How can this be tested?
dbt build --select program_summary_report