Fix KeyError in flask.py #55
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When submitting the grade form in the sample flask app (at /grade), pylti gave me this error: KeyError: 'lis_outcome_service_url' This commit turns the KeyError into a documented exception. I'm not too familiar with LTI yet so I'm not sure if this behavior is desired, but seems better to me.
nikolas
force-pushed
the
fix-response-url-error
branch
from
3a0c865 to
2f01b30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When submitting the grade form in the sample flask app
(at /grade), pylti gave me this error:
This commit turns the KeyError into a documented exception. I'm
not too familiar with LTI yet so I'm not sure if this behavior
is desired, but seems better to me.