Update to reduce type checker noise #184
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
brent-spyder
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason For Changes
When using the ToExcel exporter I noticed error messages coming from the
typeChecker()function when I used theaveragescore aggregation function. This is because the Techniques' scores come out as a float type. int is checked first, an error message is emitted, then float is checked.Summary of Changes
I updated
typeChecker()function to support a list of types, and I updated thescore()method in technique.py to utilize the change.Testing
I re-ran my code to export a layer to excel. The code worked as expected and I no longer received the error messages. I also ran the unit tests locally an everything continued to pass