Skip to content

add Java Feature Flags SDK #2181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 3, 2025
Merged

add Java Feature Flags SDK #2181

merged 8 commits into from
Nov 3, 2025
+230 −1

Conversation

@msiebert
Copy link
Contributor

No description provided.

@msiebert msiebert self-assigned this Oct 22, 2025
@msiebert msiebert requested a review from a team as a code owner October 22, 2025 23:43
@msiebert msiebert requested review from pmackle and removed request for a team October 22, 2025 23:43
@vercel
Copy link

vercel bot commented Oct 22, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs Ready Ready Preview Comment Nov 3, 2025 6:09pm

@msiebert msiebert requested a review from efahk October 22, 2025 23:44
@efahk
Copy link
Contributor

efahk commented Oct 31, 2025

image On the main page, https://docs-git-msiebert-java-ff-sdk-mixpanel.vercel.app/docs/featureflags, can you add the link for Java like the others and remove it from the 'coming soon'?

@efahk
Copy link
Contributor

efahk commented Oct 31, 2025

image
  • Definitely don't block on this, but maybe for the GA version, i'd recommend we update the startPolling to block on the 'first' flag definitions fetch, similar to the python SDK, so the customer doesn't have to wait for readiness in a timer loop

efahk
efahk approved these changes Oct 31, 2025
View reviewed changes
Copy link
Contributor

@efahk efahk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor comments - lgtm

@msiebert
Copy link
Contributor Author

image On the main page, https://docs-git-msiebert-java-ff-sdk-mixpanel.vercel.app/docs/featureflags, can you add the link for Java like the others and remove it from the 'coming soon'?

@copilot please implement this change

Copy link

Copilot AI commented Oct 31, 2025

@msiebert I've opened a new pull request, #2199, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI mentioned this pull request Oct 31, 2025
Merged
@msiebert
Copy link
Contributor Author

image * Definitely don't block on this, but maybe for the GA version, i'd recommend we update the startPolling to block on the 'first' flag definitions fetch, similar to the python SDK, so the customer doesn't have to wait for readiness in a timer loop

Sorry, I'm not sure what you mean? I get removing the block with the Thread.sleep but what do you mean about the start polling part?

@msiebert
Add Java SDK to Feature Flags documentation (#2199)
7515e9f 
* Initial plan

* Add Java SDK to Feature Flags implementation cards and remove from coming soon

Co-authored-by: msiebert <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: msiebert <[email protected]>
@msiebert
Copy link
Contributor Author

image * Definitely don't block on this, but maybe for the GA version, i'd recommend we update the startPolling to block on the 'first' flag definitions fetch, similar to the python SDK, so the customer doesn't have to wait for readiness in a timer loop

Sorry, I'm not sure what you mean? I get removing the block with the Thread.sleep but what do you mean about the start polling part?

@copilot we should just remove all the references to waiting for flags to be ready, since we fetch them automatically when starting polling. No need to add a comment describing that behavior, just remove the code blocks with Thread.sleep

Copilot AI mentioned this pull request Oct 31, 2025
Merged
Copy link

Copilot AI commented Oct 31, 2025

@msiebert I've opened a new pull request, #2200, to work on those changes. Once the pull request is ready, I'll request review from you.

@msiebert
Remove flag readiness wait loops from Java Feature Flags documentation (
f57b2c6 
#2200)

* Initial plan

* Remove Thread.sleep and readiness check references from Java FF docs

Co-authored-by: msiebert <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: msiebert <[email protected]>
@msiebert
Copy link
Contributor Author

@copilot since the SDK is currently in beta and we are using a -SNAPSHOT version, please include in the docs that the users need to set up pulling in snapshot versions. You can link to the docs for how to do this https://central.sonatype.org/publish/publish-portal-snapshots/#publishing-via-other-methods

Copy link

Copilot AI commented Oct 31, 2025

@msiebert I've opened a new pull request, #2201, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI mentioned this pull request Oct 31, 2025
Merged
@msiebert
Add snapshot repository setup for Java Feature Flags SDK (#2201)
a7f88cb 
* Initial plan

* Add snapshot version setup documentation for Java Feature Flags SDK

Co-authored-by: msiebert <[email protected]>

* Simplify snapshot version setup by linking to Sonatype docs instead of inlining

Co-authored-by: msiebert <[email protected]>

* Remove 'Installing the SDK' header

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: msiebert <[email protected]>
Co-authored-by: Mark Siebert <[email protected]>
@msiebert
Copy link
Contributor Author

msiebert commented Nov 3, 2025

@copilot add "Sonatype's" and "Sonatype" to the cspell library

Copilot AI mentioned this pull request Nov 3, 2025
Merged
Copy link

Copilot AI commented Nov 3, 2025

@msiebert I've opened a new pull request, #2204, to work on those changes. Once the pull request is ready, I'll request review from you.

@msiebert
Add Sonatype to cspell dictionary (#2204)
9f3c571 
* Initial plan

* Add Sonatype and Sonatype's to cspell dictionary

Co-authored-by: msiebert <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: msiebert <[email protected]>
@msiebert msiebert enabled auto-merge (squash) November 3, 2025 18:04
@msiebert msiebert merged commit 14c3b7e into main Nov 3, 2025
9 checks passed
@msiebert msiebert deleted the msiebert-java-ff-sdk branch November 3, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efahk efahk efahk approved these changes

@pmackle pmackle Awaiting requested review from pmackle pmackle is a code owner automatically assigned from mixpanel/docs-reviewers

Assignees

@msiebert msiebert

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@msiebert @efahk