Use native query selector parser in track_links and track_forms
#382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pistvan
changed the title
track_links and track_formstrack_links and track_forms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old query selector parsing logic in
_.dom_query's internalgetElementsBySelectormethod is (not) a bit of mess: it works for many cases, but cannot resolve any combined selector such asdiv.foo.barora.btn[href="#"](not to mention data attributes containing a hyphen, see #62).This piece of code has not been changed in the last 7 years, and I'm wondering whether
document.querySelectorAllcould be used here, since these days browsers are all support that, I think. (anyway, according to CanIUse.com, it had very good support in 2016 as well.)