Skip to content

Fixed data was truncated on a property value longer than 255 chars #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixed data was truncated on a property value longer than 255 chars #451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4749a5b
fixed truncate data on a property value longer than 255 chars
Oct 15, 2024
0767a81
fixed truncate data on a property value longer than 255 chars
Oct 15, 2024
c7ecd5e
fixed truncate data on a property value longer than 255 chars
Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/mixpanel-core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,8 @@ var DEFAULT_CONFIG = {
'record_max_ms': MAX_RECORDING_MS,
'record_min_ms': 0,
'record_sessions_percent': 0,
'recorder_src': 'https://cdn.mxpnl.com/libs/mixpanel-recorder.min.js'
'recorder_src': 'https://cdn.mxpnl.com/libs/mixpanel-recorder.min.js',
'max_property_length': 255 //Default is 255, -1: For no truncate
};

var DOM_LOADED = false;
Expand Down Expand Up @@ -877,7 +878,7 @@ MixpanelLib.prototype._encode_data_for_request = function(data) {

// internal method for handling track vs batch-enqueue logic
MixpanelLib.prototype._track_or_batch = function(options, callback) {
var truncated_data = _.truncate(options.data, 255);
var truncated_data = _.truncate(options.data, this.get_config('max_property_length') || 255);
var endpoint = options.endpoint;
var batcher = options.batcher;
var should_send_immediately = options.should_send_immediately;
Expand Down
2 changes: 1 addition & 1 deletion src/mixpanel-people.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ MixpanelPeople.prototype._send_request = function(data, callback) {
callback(-1);
}
}
return _.truncate(date_encoded_data, 255);
return _.truncate(date_encoded_data, this.get_config('max_property_length') || 255);
}

return this._mixpanel._track_or_batch({
Expand Down