Skip to content

fix: add typings for alternative entrypoints #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: add typings for alternative entrypoints #506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dist/mixpanel-core.cjs.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export * from '../src/index';
1 change: 1 addition & 0 deletions dist/mixpanel-with-async-recorder.cjs.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export * from '../src/index';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code isn't going to be copied into dist/ as part of the build process (your current branch will have this change overridden when running npm run build-dist). I think the easiest way would be to add additional entrypoints in package.json like

mixpanel-js/package.json

Lines 27 to 31 in 012f1ee

"./src/loaders/loader-module-core": {
"types": "./src/index.d.ts",
"import": "./src/loaders/loader-module-core.js",
"require": "./src/loaders/loader-module-core.js"
},
- or updating rollup config to generate these type files

Copy link
Author

@levrik levrik Sep 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. I opened this PR before you introduced the exports in package.json. I'll try to revisit this asap.
Actually these pre-built files aren't even accessible due to the introduction of exports anymore atm, not only the typings are missing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can take this over if you can't get it to it, apologies for the trouble. Since we made these custom builds we said in our docs to import the non-built loaders (e.g. src/loaders/loader-module-core) because I thought that would be preferable.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be great if you could handle it. I would close this PR then.

1 change: 1 addition & 0 deletions src/loaders/loader-module-core.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export * from '../index';
1 change: 1 addition & 0 deletions src/loaders/loader-module-with-async-recorder.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export * from '../index';