Paths to elf, hex, lst and map files are more flexible #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix problem with file location when building in custom directory. Add frequency speed into compiler flags.
klaussnd
reviewed
Oct 1, 2021
| @@ -166,26 +166,30 @@ function(add_avr_executable EXECUTABLE_NAME) | |||
| message(FATAL_ERROR "No source files given for ${EXECUTABLE_NAME}.") | |||
| endif(NOT ARGN) | |||
|
|
|||
| set(target_name ${EXECUTABLE_NAME}${MCU_TYPE_FOR_FILENAME}) | |||
| set(bin_dir "${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_BUILD_TYPE}") | |||
There was a problem hiding this comment.
This is changing the output directory, i.e. it changes behaviour, doesn't it?
There was a problem hiding this comment.
Yes, it changes build directory, respectively define relation between build directory and output file. In previous case it as relative to executed cmake command.
Not saying you have to accept it, but in general, output files shall be defined as inside "build" directory.
There was a problem hiding this comment.
Normally the user chooses the build directory depending on the needs, like
cmake . -Bbuild-firmware
where the build is done in build-firmware. IMHO the CMake code should respect the choice of the user and not change it in an arbitrary way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix problem with file location when building in customdirectory.
Add frequency speed into compiler flags.
Unless variable is cache, they should be lower_case. But if required, I can change it to UPPER_CASE.