fix(deps): refresh express-rate-limit to pull in patched ip-address - #1245
Draft
ChrisPrapas wants to merge 1 commit into
Draft
ChrisPrapas wants to merge 1 commit into
ChrisPrapas wants to merge 1 commit into
Conversation
bun.lock pinned express-rate-limit@8.2.1, which depends on the exact version ip-address@10.0.1. That version is affected by five published advisories (GHSA-v2v4-37r5-5v8g, GHSA-mwp4-54f8-5fhr, GHSA-rpw4-54j3-4h4q, GHSA-h3mg-xc3c-68pw, GHSA-j6r3-76f7-8jcv), fixed by 10.7.1. Updates the transitive entries only: express-rate-limit 8.2.1 -> 8.7.0 (ip-address ^10.2.0) and ip-address 10.0.1 -> 10.7.3. package.json is unchanged; the range from @modelcontextprotocol/sdk already allows it. Refs mksglu#1225 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What / Why / How
Fixes #1225.
bun.lockresolvedexpress-rate-limit@8.2.1, which depends on the exact versionip-address@10.0.1. That version is affected by five published advisories, all fixed in 10.7.1 or earlier:Address4decodes leading-zero octets as decimal, which enables SSRF and trust-boundary bypassAddress6.isLinkLocal()checks fe80::/64 instead of fe80::/10isInSubnet()compares addresses of different familiesAddress6Address6HTML-emitting methodsThe package is only reached through
@modelcontextprotocol/sdk->express-rate-limit, so the exposure is limited to that chain. Refreshing the lock is still the cheapest way to clear the advisories.This PR only refreshes the two transitive lock entries (
bun update express-rate-limit ip-address --lockfile-only):express-rate-limit8.2.1 -> 8.7.0 (now depends onip-address ^10.2.0)ip-address10.0.1 -> 10.7.3package.jsonis unchanged. The^8.2.1range from the SDK already allows the new version.Affected platforms
Test plan
No source changes, so no new tests. Checked on a fresh checkout of
next:bun install --frozen-lockfileaccepts the new locktsc --noEmitpassesvitest run tests/core: 16 files, 994 passed, 1 skippedimport('express-rate-limit')and the SDK'sserver/mcp.jsboth loadexpress-rate-limit@8.7.0andip-address@10.7.3I ran the core test directory only, not the full suite or the cross-platform CI matrix.
Checklist
npm testpasses (core tests only, see above; full suite left to CI)npm run typecheckpassesnextbranchThis change was prepared with the help of an AI assistant (Claude Code) and checked by the commands above.
🤖 Generated with Claude Code