Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #589

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Update README.md #589

merged 1 commit into from
Oct 4, 2024

Conversation

gopi-suvanam
Copy link
Contributor

Added dynamic import syntax for loading from CDN.

@CharlieFRuan
Copy link
Contributor

Thanks for your contribution! Out of curiosity, I tried it out in Scribbler but ran into the following, do you know why this may be the case:
image

@gopi-suvanam
Copy link
Contributor Author

hi Charlie, Thanks for trying out.
Scribbler runs the notebook in a sandbox by default for web-security. This disables access to cookies/cache/local storage etc. For running WebLLM, you will have to take it out of sandbox manually by clicking the red ⤯ button at top-right corner or by clicking "Edit->Trust the NB".
Here is a working notebook on WebLLM with loading the library and running the model: https://app.scribbler.live/?jsnb=https://examples.scribbler.live/WebLLM-Experiments.jsnb

@CharlieFRuan
Copy link
Contributor

Tried it out, works smoothly. Thank you so much!

@CharlieFRuan CharlieFRuan merged commit f142da7 into mlc-ai:main Oct 4, 2024
1 check passed
@gopi-suvanam
Copy link
Contributor Author

gopi-suvanam commented Oct 4, 2024 via email

jzhao62 pushed a commit to jzhao62/web-llm that referenced this pull request Dec 8, 2024
Added dynamic import syntax for loading from CDN.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants