Repository navigation
Send point.yaml and system_power.json, with derived power, on runs create - #118
Merged
Merged
Conversation
runs create now sends point.yaml as point_config and, when present, system_power.json as system_power with a derived object computed by the checker's own power code: provisioned_power_kw, point_power_kw, system_tps_per_kw and mlc_estimated_power. The new submission_checker.power_summary.derive_point_power is importable so the review-repo sync job computes the same figures. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pairs with mlcommons/mlperf-endpoints-api#28, which adds
runs.point_configandruns.system_power.Today only
system_desc.json,config.yamland the result summary reach the database.point.yamlandsystem_power.jsontravel only inside the GCS archives, so the visualizer can't see a point's offline mode, itsnodes_used, or any power figure.runs createnow sends:point_config:point.yaml, as parsed.system_power: when the run folder hassystem_power.json, the descriptor unchanged, plus aderivedobject:provisioned_power_kwnullif E.7 rejects the descriptorpoint_power_kwnodes_usedsystem_tps_per_kwsystem_tps / point_power_kw, to one decimal (§4.5.2)mlc_estimated_powerestimated,problemsnullNew
submission_checker.power_summary.derive_point_power:SystemPower.compute()andPowerComputation.point_power_kw(), so a stored figure can never disagree with what compliance accepts.nodes_usedis something the checker would reject, the affected figure isnullandproblemssays why.derivedexists only in the database copy.Compatibility: an API without #28 ignores the new fields, because FastAPI drops unknown body keys, so this can ship in either order.
Testing:
tests/submission_checker/test_power_summary.pycovers: fully engaged, scaled bynodes_used, Appendix D default, submitter flag, over-provisioned and unknown-ensemblenodes_used, invalid descriptor, missing throughput, no mutation.test_builder.py::test_a_separate_accuracy_run_still_wins, which fails on main too, on local Python 3.10.8 (tarfile.extractall(filter=)); CI uses a newer patch release.docs/endpoints-cli/usage/runs.md.🤖 Generated with Claude Code