Repository navigation
fix(openai): preserve reasoning in mixed content deltas - #526
Merged
hvagadia merged 2 commits intoOct 5, 2026
Merged
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
github-actions
Bot
added
the
size/normal
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #526 +/- ##
=======================================
Coverage ? 81.35%
=======================================
Files ? 157
Lines ? 22494
Branches ? 0
=======================================
Hits ? 18301
Misses ? 4193
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
leopck
approved these changes
Oct 5, 2026
leopck
left a comment
leopck
left a comment
Collaborator
There was a problem hiding this comment.
valid issue, I've manually checked on vLLM that this is how it is working and this is truly missing the contents
arekay-nv
approved these changes
Oct 5, 2026
arekay-nv
left a comment
arekay-nv
left a comment
Collaborator
There was a problem hiding this comment.
LGTM.
Followup PR with more coverage.
Collaborator
Author
|
cc: @tianmu-li might have slight perf impact, please check your runs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an OpenAI streaming delta contains both content and reasoning, the accumulator's
if/elifdrops the reasoning. Accumulate both fields independently and preserve both in emitted chunks.Adds regression coverage for
reasoning_contentandreasoning, with first-chunk-only and full streaming. All 60 OpenAI unit tests and all pre-commit checks pass.