Repository navigation
Say pipeline-assigned fields are not in system_desc.json - #144
Open
arav-agarwal2 wants to merge 3 commits into
Open
arav-agarwal2 wants to merge 3 commits into
arav-agarwal2 wants to merge 3 commits into
Conversation
The submission ID is assigned by the pipeline (8.5) and lives only in the <submission_id>/ directory (8.1). Say so in 8.2 and 8.5, and say a key left over from a v0.7 template is dropped by the tooling and not flagged. Fixes #143. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N2grVghMMtp7LPurYJ5o35
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Like the submission ID, the pipeline assigns the submission date (Submission Rules 5.2) and the publication date (Submission Rules 4.2), and v0.7 templates carried both. Extend the 8.2 note to all three. Part of #143. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N2grVghMMtp7LPurYJ5o35
arav-agarwal2
changed the title
There was a problem hiding this comment.
🟢 Approval recommended
The documentation is coherent and accurate aside from a minor non-blocking cross-reference issue.
1 open finding
What changed in this PR
Clarifies that pipeline-assigned metadata is excluded from submitter-provided system_desc.json files.
Changes:
- Documents handling of submission, submission-date, and publication-date fields.
- Clarifies where the generated submission ID appears.
| File | Description |
|---|---|
endpoints_rules.md |
Documents pipeline-assigned fields and submission ID placement. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Updated references to submission rules and clarified submission ID recording. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #143.
The submission pipeline assigns the submission ID (§8.5), the submission date, and the publication date. The v1.0 §8.2 table already omits all three, but nothing says so, and
system_desc.jsonfiles built from the v0.7 template still carrysubmission_id,submission_date, andpublish_datekeys.system_desc.jsondoes not carrysubmission_id,submission_date, orpublish_date; says where each comes from (the[submission_id]/directory, Submission Rules §5.2, and Submission Rules §4.2); and says a key left over from an earlier round's template is dropped by the submission tooling and not flagged by the compliance validator.A companion PR, mlcommons/endpoints-submission-cli#117, makes the tooling match.
CI note:
pre-commitfails here for the same reason it fails onmain: eight over-length lines already in the tree (endpoints_rules.md:1260andendpoints_submission_rules.mdlines 131, 138, 685, 686, 688, 696, 698). None are touched by this PR; the lines it adds are within 100 characters.🤖 Generated with Claude Code
https://claude.ai/code/session_01N2grVghMMtp7LPurYJ5o35