Repository navigation
Conversation
superdosh
commented
Dec 9, 2025
superdosh
commented
Contributor
- Upgrade mlflow (needed due to a modelbench pyarrow upgrade)
- Add scripts to validate versions across mlflow dockerfile and poetry env match
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Contributor
Author
|
New scripts pass current version. Now will upgrade modelbench / mlflow. |
bkorycki
approved these changes
Dec 9, 2025
|
|
||
| - name: Install poetry | ||
| run: pipx install "poetry == 1.8.5" | ||
| run: pipx install poetry |
Contributor
There was a problem hiding this comment.
why not specify the version anymore?
Contributor
Author
There was a problem hiding this comment.
We were pinned to a very old version because of some weirdness (in modelbench) that I never fully understood, but I figure that's not necessary here anymore -- I think it was actually driven by modelbench-private? Potentially pinning to some newer version is good, but at least we shouldn't be stuck on 1 if not necessary. Going to leave it open for now!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.