Skip to content

Laravel 12.x Compatibility #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 27 additions & 23 deletions .github/workflows/validate.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
name: "Validate"
name: Validate

on:
pull_request:
push:
Expand All @@ -15,26 +16,8 @@ jobs:
strategy:
fail-fast: false
matrix:
php-version:
- 7.1
- 7.2
- 7.3
- 7.4
- 8.0
- 8.1
- 8.2
- 8.3
laravel-version:
# Purposefully omitting 5.5.*, it cannot be installed due to a conflict with orchestra/testbench
- 5.6.*
- 5.7.*
- 5.8.*
- ^6
- ^7
- ^8
- ^9
- ^10
- ^11
php-version: [7.1, 7.2, 7.3, 7.4, 8.0, 8.1, 8.2, 8.3]
laravel-version: ['5.6.*', '5.7.*', '5.8.*', '12.*', ^6, ^7, ^8, ^9, ^10, ^11]
exclude:
- php-version: 7.1
laravel-version: ^6
Expand Down Expand Up @@ -114,38 +97,59 @@ jobs:
laravel-version: ^6
- php-version: 8.3
laravel-version: ^7
- laravel-version: 12.*
php-version: 7.1
- laravel-version: 12.*
php-version: 7.2
- laravel-version: 12.*
php-version: 7.3
- laravel-version: 12.*
php-version: 7.4
- laravel-version: 12.*
php-version: 8.0
- laravel-version: 12.*
php-version: 8.1


steps:
- uses: actions/checkout@v4


- uses: shivammathur/setup-php@v2
with:
extensions: ${{ env.REQUIRED_PHP_EXTENSIONS }}
php-version: ${{ matrix.php-version }}


- run: composer require illuminate/support:${{ matrix.laravel-version }} --no-interaction --prefer-dist --no-progress

- if: matrix.laravel-version == '^11'
- if: "matrix.laravel-version == '^11'"
run: vendor/bin/phpunit --coverage-filter=src
- if: matrix.laravel-version != '^11'

- if: "matrix.laravel-version != '^11'"
run: vendor/bin/phpunit

coverage:
runs-on: ubuntu-20.04


steps:
- uses: actions/checkout@v4


- uses: shivammathur/setup-php@v2
with:
coverage: pcov
extensions: ${{ env.REQUIRED_PHP_EXTENSIONS }}
php-version: 8.3


- uses: ramsey/composer-install@v3


- run: vendor/bin/phpunit --coverage-clover=coverage.xml --coverage-filter=src


- uses: codecov/codecov-action@v4
with:
token: ${{ secrets.CODECOV_TOKEN }}
6 changes: 3 additions & 3 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,13 @@
"homepage": "https://github.com/mll-lab/laravel-comment",
"require": {
"php": "^7.1 || ^8",
"illuminate/contracts": "~5.5.0 || ~5.6.0 || ~5.7.0 || ~5.8.0 || ^6 || ^7 || ^8 || ^9 || ^10 || ^11",
"illuminate/support": "~5.5.0 || ~5.6.0 || ~5.7.0 || ~5.8.0 || ^6 || ^7 || ^8 || ^9 || ^10 || ^11"
"illuminate/contracts": "~5.5.0 || ~5.6.0 || ~5.7.0 || ~5.8.0 || ^6 || ^7 || ^8 || ^9 || ^10 || ^11 || ^12.0",
"illuminate/support": "~5.5.0 || ~5.6.0 || ~5.7.0 || ~5.8.0 || ^6 || ^7 || ^8 || ^9 || ^10 || ^11 || ^12.0"
},
"require-dev": {
"ergebnis/composer-normalize": "^2",
"fakerphp/faker": "^1.8",
"orchestra/testbench": "~3.5.0 || ~3.6.0 || ~3.7.0 || ~3.8.0 || ~3.9.0 || ^4 || ^5 || ^6 || ^7 || ^8 || ^9",
"orchestra/testbench": "~3.5.0 || ~3.6.0 || ~3.7.0 || ~3.8.0 || ~3.9.0 || ^4 || ^5 || ^6 || ^7 || ^8 || ^9 || ^10.0",
"phpunit/phpunit": "^7.5 || ^8.4 || ^9 || ^10 || ^11"
},
"autoload": {
Expand Down