Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend id vs id rule and add LabID rule #42

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

simbig
Copy link
Contributor

@simbig simbig commented Dec 6, 2024

  • Added automated tests
  • Documented for all relevant versions
  • Updated the changelog

Changes

  • Refactored MLL\Utils\PHPStan\Rules\NameIdToIDRule to handle variable names, parameter names, method names and class names for incorrect capitalization of "Id"
  • Add 'Idt' and 'Identical' to the list of incorrect capitalizations for "Id" of MLL\Utils\PHPStan\Rules\NameIdToIDRule
  • Add RuleIdentifier 'mllLabRules.nameIdToID' to MLL\Utils\PHPStan\Rules\NameIdToIDRule
  • Add PHPStan-Rule MLL\Utils\PHPStan\Rules\CanonicalCapitalizations to check spelling of LabID

Breaking changes

  • Renamed class MLL\Utils\PHPStan\Rules\VariableNameIdToIDRule to MLL\Utils\PHPStan\Rules\NameIdToIDRule

Simon Bigelmayr added 14 commits December 6, 2024 08:17
- Refactored `MLL\Utils\PHPStan\Rules\VariableNameIdToIDRule` to `MLL\Utils\PHPStan\Rules\NameIdToIDRule` to handle variable names, method names and class names for incorrect capitalization of "Id"
- Add `Idt` to the list of incorrect capitalizations for "Id" of `MLL\Utils\PHPStan\Rules\NameIdToIDRule`
- Refactored `MLL\Utils\PHPStan\Rules\VariableNameIdToIDRule` to `MLL\Utils\PHPStan\Rules\NameIdToIDRule` to handle variable names, method names and class names for incorrect capitalization of "Id"
- Add `Idt` to the list of incorrect capitalizations for "Id" of `MLL\Utils\PHPStan\Rules\NameIdToIDRule`
…d-id-vs-ID-rule

# Conflicts:
#	src/PHPStan/Rules/NameIdToIDRule.php
@simbig simbig requested a review from spawnia December 6, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants