Skip to content

Comments

fix: display Input prefix and clear symbol correctly#273

Merged
kilya11 merged 3 commits intomasterfrom
fix-input-inline-elements
Apr 30, 2025
Merged

fix: display Input prefix and clear symbol correctly#273
kilya11 merged 3 commits intomasterfrom
fix-input-inline-elements

Conversation

@spawnia
Copy link
Member

@spawnia spawnia commented Jul 3, 2024

image

@kilya11
Copy link
Member

kilya11 commented Apr 30, 2025

Current definition of the less-variable @ant-prefix leads to class names like: .'mll-ant'-input-clear-icon {}
That's why the styles are being ignored.

@kilya11 kilya11 marked this pull request as ready for review April 30, 2025 07:53
@kilya11 kilya11 requested a review from simbig April 30, 2025 07:53
@kilya11 kilya11 force-pushed the fix-input-inline-elements branch from 702c203 to 7a30893 Compare April 30, 2025 07:56
@kilya11 kilya11 self-assigned this Apr 30, 2025
@kilya11 kilya11 merged commit 7a984a8 into master Apr 30, 2025
6 checks passed
@kilya11 kilya11 deleted the fix-input-inline-elements branch April 30, 2025 11:03
github-actions bot pushed a commit that referenced this pull request Apr 30, 2025
## [19.9.1](v19.9.0...v19.9.1) (2025-04-30)

### Bug Fixes

* display Input prefix and clear symbol correctly ([#273](#273)) ([7a984a8](7a984a8))
@github-actions
Copy link

🎉 This PR is included in version 19.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kilya11 kilya11 requested a review from Copilot May 7, 2025 08:02
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the display issue of the Input prefix and clear symbol in the Input component demos. Key changes include updating the import of TextAreaProps, adding a BarcodeOutlined prefix with allowClear to one demo, and adding a new Form.Item showcasing Input.TextArea with allowClear behavior.

Files not reviewed (1)
  • src/antd.less: Language not supported
Comments suppressed due to low confidence (2)

src/Input/index.stories.tsx:17

  • Ensure that importing TextAreaProps from './index' aligns with the component's intended public API and does not break any existing contracts.
import { Input, InputNumber, TextAreaProps } from './index';

src/Input/index.stories.tsx:26

  • [nitpick] Verify that using '' for layout in the 'Text' story matches the intended UX design and maintains consistency across similar demos.
<Space vertical>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants