Skip to content

Fix/issue 83 cropping perf #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jayant-kernel wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix/issue 83 cropping perf #96

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
90ae02f
Optimize domain cropping padded hull evaluation
Feb 25, 2026
60ef889
Strip excess comments
Feb 25, 2026
8381060
style: remove implementation comments and clean benchmark script
Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 21 additions & 11 deletions mllam_data_prep/ops/cropping.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,22 @@ def create_convex_hull_mask(ds: xr.Dataset, ds_reference: xr.Dataset) -> xr.Data

chull_lam = SphericalPolygon.convex_hull(da_ref_xyz.values)

# call .load() to avoid using dask arrays in the following apply_ufunc
def _mask_points_in_hull(lon_vals, lat_vals):
shape = lon_vals.shape
lon = lon_vals.ravel()
lat = lat_vals.ravel()

xyz_pts = np.array(sg.vector.lonlat_to_vector(lon, lat)).T
mask = np.array([chull_lam.contains_point(pt) for pt in xyz_pts], dtype=bool)

return mask.reshape(shape)

da_interior_mask = xr.apply_ufunc(
chull_lam.contains_lonlat, da_lon.load(), da_lat.load(), vectorize=True
_mask_points_in_hull,
da_lon.load(),
da_lat.load(),
dask="parallelized",
output_dtypes=[bool],
).astype(bool)
da_interior_mask.attrs[
"long_name"
Expand Down Expand Up @@ -241,15 +254,12 @@ def distance_to_convex_hull_boundary(
(da_xyz_chull[-1], da_xyz_chull[0])
] # Add arc from last to first point

# Calculate minimum distance to each arc and take the minimum
# distance over all arcs
mindist_to_ref = np.stack(
[
shortest_distance_to_arc(da_xyz, arc_start, arc_end)
for arc_start, arc_end in chull_arcs
],
axis=0,
).min(axis=0)
mindist_to_ref = np.full(da_xyz.shape[0], np.inf)
xyz_arr = da_xyz.values

for arc_start, arc_end in chull_arcs:
dist = shortest_distance_to_arc(xyz_arr, arc_start, arc_end)
np.minimum(mindist_to_ref, dist, out=mindist_to_ref)

da_mindist_to_ref = xr.DataArray(
mindist_to_ref, coords=ds_exterior_lat.coords, dims=ds_exterior_lat.dims
Expand Down