Fix/issue 61 variable coord selection#97
Open
Jayant-kernel wants to merge 3 commits intomllam:mainfrom
Open
Conversation
leifdenby
requested changes
Feb 27, 2026
| chull_lam = SphericalPolygon.convex_hull(da_ref_xyz.values) | ||
|
|
||
| # call .load() to avoid using dask arrays in the following apply_ufunc | ||
| def _mask_points_in_hull(lon_vals, lat_vals): |
Member
There was a problem hiding this comment.
I don't think this relates to the issue you are fixing here, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR completely decouples variable sampling coordinates during extraction in create_dataset. Previously, extracting variables with disjoint coordinates (like
uat altitudes[100, 50]vsvat[100, 75]) would mistakenly align and broadcast their Union dimensions if appended directly back onto a sharedxr.Dataset.I have resolved this by substituting the intermediate compilation
ds = xr.Dataset()into a native Python dictionaryds = {}until the final combination phase. This completely negates implicit NaN expansion.No new external dependencies were introduced, and ops/stacking.py + ops/mapping.py now support unmerged dictionaries natively.
Issue Link
Closes #61
Type of change
Checklist before requesting a review
pullwith--rebaseoption if possible).Checklist for reviewers
Each PR comes with its own improvements and flaws. The reviewer should check the following:
Author checklist after completed review
reflecting type of change (add section where missing):
Checklist for assignee