Merged
Conversation
Contributor
Author
|
@leifdenby @khintz we probably need to make a release of mllam-data-prep, because all neural-lam tests will fail until the mdp fix from mllam/mllam-data-prep#77 is in. |
Contributor
|
Hi @SimonKamuk what is left for this to be merged? Mllam-data-prep has been released and I just retriggered the failing pre-commit actions which seem to have been caused previously by an issue on GitHub's side. |
This was referenced Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
fixes 2 different errors in the tests:
We always use the latests pytorch version compatible with neural lam for testing, but the newest version has removed support for cuda 12.4 which we had pinned on the gpu runner. This is now updated to cuda 12.8 instead.
pre-commit v2.0.3 has been deprecated and raises an error, so it was updated to version 3.0.1 instead.
Type of change
Checklist before requesting a review
pullwith--rebaseoption if possible).Checklist for reviewers
Each PR comes with its own improvements and flaws. The reviewer should check the following:
Author checklist after completed review
reflecting type of change (add section where missing):
Checklist for assignee