Skip to content

Fix cicd tests#140

Merged
SimonKamuk merged 3 commits intomllam:mainfrom
SimonKamuk:fix/test_runners
Jun 10, 2025
Merged

Fix cicd tests#140
SimonKamuk merged 3 commits intomllam:mainfrom
SimonKamuk:fix/test_runners

Conversation

@SimonKamuk
Copy link
Copy Markdown
Contributor

@SimonKamuk SimonKamuk commented Apr 25, 2025

Describe your changes

fixes 2 different errors in the tests:

We always use the latests pytorch version compatible with neural lam for testing, but the newest version has removed support for cuda 12.4 which we had pinned on the gpu runner. This is now updated to cuda 12.8 instead.

pre-commit v2.0.3 has been deprecated and raises an error, so it was updated to version 3.0.1 instead.

Type of change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📖 Documentation (Addition or improvements to documentation)

Checklist before requesting a review

  • My branch is up-to-date with the target branch - if not update your fork with the changes from the target branch (use pull with --rebase option if possible).
  • I have performed a self-review of my code
  • For any new/modified functions/classes I have added docstrings that clearly describe its purpose, expected inputs and returned values
  • I have placed in-line comments to clarify the intent of any hard-to-understand passages of my code
  • I have updated the README to cover introduced code changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have given the PR a name that clearly describes the change, written in imperative form (context).
  • I have requested a reviewer and an assignee (assignee is responsible for merging). This applies only if you have write access to the repo, otherwise feel free to tag a maintainer to add a reviewer and assignee.

Checklist for reviewers

Each PR comes with its own improvements and flaws. The reviewer should check the following:

  • the code is readable
  • the code is well tested
  • the code is documented (including return types and parameters)
  • the code is easy to maintain

Author checklist after completed review

  • I have added a line to the CHANGELOG describing this change, in a section
    reflecting type of change (add section where missing):
    • added: when you have added new functionality
    • changed: when default behaviour of the code has been changed
    • fixes: when your contribution fixes a bug

Checklist for assignee

  • PR is up to date with the base branch
  • the tests pass
  • author has added an entry to the changelog (and designated the change as added, changed or fixed)
  • Once the PR is ready to be merged, squash commits and merge the PR.

@SimonKamuk SimonKamuk requested a review from khintz April 25, 2025 12:40
@SimonKamuk
Copy link
Copy Markdown
Contributor Author

@leifdenby @khintz we probably need to make a release of mllam-data-prep, because all neural-lam tests will fail until the mdp fix from mllam/mllam-data-prep#77 is in.

@observingClouds
Copy link
Copy Markdown
Contributor

Hi @SimonKamuk what is left for this to be merged? Mllam-data-prep has been released and I just retriggered the failing pre-commit actions which seem to have been caused previously by an issue on GitHub's side.

Copy link
Copy Markdown
Contributor

@observingClouds observingClouds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SimonKamuk SimonKamuk merged commit 3f8e3ba into mllam:main Jun 10, 2025
9 of 11 checks passed
@SimonKamuk SimonKamuk deleted the fix/test_runners branch June 10, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants